Repository navigation
Install curl in all node:20-alpine test app images - #388
Merged
Merged
Conversation
The integration test setup runs curl inside the app1 and app2 pods to smoke-test the backends before the suite starts. node:20-alpine does not ship curl, unlike the Debian-based node:8 image used before apache#387, so kubectl exec failed with 'executable file not found in $PATH' and all 31 tests errored in setup_module. Add curl to every Node image under k8s/images so the apps behave the same way regardless of which one the tests exec into. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The integration test setup runs curl inside the app1 and app2 pods to smoke-test the backends before the suite starts. node:20-alpine does not ship curl, unlike the Debian-based node:8 image used before #387, so kubectl exec failed with 'executable file not found in $PATH' and all 31 tests errored in setup_module.
Add curl to every Node image under k8s/images so the apps behave the same way regardless of which one the tests exec into.