Repository navigation
Conversation
getOperatorsDifference compared each operator property with !=, so object- and array-valued properties were compared by reference and always reported as changed in the workflow version diff, and the loop iterated only the first operator's keys, so a property present only in the second version was never reported. It now compares with lodash isEqual over the union of both operators' property keys, so only genuinely changed properties are highlighted and added properties are detected. workflow-version.service.spec adds cases that deeply-equal object and array properties are not flagged, that a changed nested value is flagged, and that a property present only in the second operator is flagged.
Contributor
Automated Reviewer SuggestionsBased on the
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #9585 +/- ##
=========================================
Coverage 91.57% 91.57%
Complexity 5158 5158
=========================================
Files 1300 1300
Lines 58092 58094 +2
Branches 7615 7615
=========================================
+ Hits 53195 53197 +2
Misses 2959 2959
Partials 1938 1938
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this PR?
Any related issues, documentation, discussions?
Closes: #9582
How was this PR tested?
cd frontend && ./node_modules/.bin/ng test --watch=false --include='src/app/dashboard/service/user/workflow-version/workflow-version.service.spec.ts'; expect the suite green, including new cases that deeply-equal object/array properties are not flagged, a changed nested value is flagged, and a property present only in the second operator is flagged.Was this PR authored or co-authored using generative AI tooling?
Co-authored with Claude Opus 4.8 in compliance with ASF