Skip to content

fix(frontend): unfreeze the agent panel on first open - #9579

Draft
bobbai00 wants to merge 4 commits into
apache:mainfrom
bobbai00:fix/agent-panel-freeze
Draft

bobbai00 wants to merge 4 commits into
apache:mainfrom
bobbai00:fix/agent-panel-freeze

Conversation

@bobbai00

Copy link
Copy Markdown
Contributor

What changes were proposed in this PR?

On a first visit the AI Agents panel did not respond: clicking a model card did nothing, so no agent could be created. The panel loads minimized, and ng-zorro 21 hides an inactive tab pane only when its fade-out transition ends, which never happens inside a hidden panel. Each listed agent's chat pane stayed, invisible, over the "+ Agent" tab and took its clicks. The agent tabs no longer animate, so an inactive pane is hidden at once.

Three smaller fixes:

  • It opened past the window's right edge by the sidebar's width. It is now placed against the viewport, like the property editor.
  • The computing-unit notice was squeezed beside the button. It now spans the form above it.
  • A prompt sent right after an agent's tab opened made the workspace lose the workflow's id and name, locking that agent's own tab. The reload now keeps them.

Any related issues, documentation, discussions?

Part of #9575: this fixes the model card and a user's own chat locking on the open workflow. A chat bound to another workflow still shows the lock.

How was this PR tested?

New specs cover the hidden pane and the kept workflow id; each fails without its fix. Also run in headless Chromium against a local stack, as two users with a real model. On main every click over the form lands on the invisible pane. With this branch an agent is created and answers.

Was this PR authored or co-authored using generative AI tooling?

Generated-by: Claude Code (Claude Fable 5.2)

With pane animations on, ng-zorro hides an inactive tab pane only when its
fade-out transition ends. The agent panel loads minimized, with its body
hidden, and no transition ends in a hidden subtree. The panes of the agents
listed meanwhile stayed, invisible, over the registration tab and took every
click, so a user could not select a model or create an agent.

The agent tabs no longer animate, so an inactive pane is hidden at once.
The panel was placed at the right edge of its host, which is as wide as the
viewport but starts after the dashboard sidebar. It opened past the window's
right edge by the sidebar's width, hiding its minimize button and half of the
form. It is now placed against the viewport, as the property editor is.
The notice that a computing unit is needed sat beside the button, squeezed
into what the button's minimum width left over. It now spans the form above
the button.
An agent's step can reach the page before the agent's workflow has been
fetched, and then carries the content alone. Reloading the workspace from it
dropped the open workflow's id and name: the title went blank and the agent's
own tab locked as belonging to a different workflow. The reload now keeps the
open workflow's metadata for whatever the agent's workflow does not carry.
@github-actions

Copy link
Copy Markdown
Contributor

Automated Reviewer Suggestions

Based on the git blame history of the changed files, we recommend the following reviewers:

  • Contributors with relevant context: @eugenegujing, @aglinxinyuan
    You can notify them by mentioning @eugenegujing, @aglinxinyuan in a comment.

@Yicong-Huang Yicong-Huang added the release/v1.3 back porting to release/v1.3 label Nov 20, 2026
@github-actions github-actions Bot added fix frontend Changes related to the frontend GUI and removed release/v1.3 back porting to release/v1.3 labels Nov 20, 2026
@Yicong-Huang Yicong-Huang added the release/v1.2 back porting to release/v1.2 label Nov 20, 2026
@github-actions
github-actions Bot requested review from mengw15 and xuang7 November 20, 2026 22:19
@github-actions

Copy link
Copy Markdown
Contributor

Backport auto-label report

This fix: PR was checked against each actively-supported release branch. A release/* label nominates a backport target; the branch's release manager approving this PR is what sends the fix there. The required Backport Approvals check stays red until every label below is approved, so each manager either approves or removes their own label — which is why the labels left on a merged PR are exactly the branches it reached.

Release branch Analysis
✅ release/v1.3 Change detected on this branch — label added; this fix is queued to backport here. @mengw15 decides: approving sends the fix here, removing this label declines it. The merge waits on one or the other. Review requested.
✅ release/v1.2 Change detected on this branch — label added; this fix is queued to backport here. @xuang7 decides: approving sends the fix here, removing this label declines it. The merge waits on one or the other. Review requested.

Auto-label run.

@codecov-commenter

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.57%. Comparing base (7f9bdf3) to head (9310e4e).

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #9579   +/-   ##
=========================================
  Coverage     91.57%   91.57%           
  Complexity     5158     5158           
=========================================
  Files          1300     1300           
  Lines         58092    58092           
  Branches       7615     7615           
=========================================
+ Hits          53195    53196    +1     
+ Misses         2959     2958    -1     
  Partials       1938     1938           
Flag Coverage Δ *Carryforward flag
access-control-service 77.44% <ø> (ø) Carriedforward from 7f9bdf3
agent-service 99.56% <ø> (ø) Carriedforward from 7f9bdf3
amber 85.43% <ø> (ø) Carriedforward from 7f9bdf3
computing-unit-managing-service 63.88% <ø> (ø) Carriedforward from 7f9bdf3
config-service 87.50% <ø> (ø) Carriedforward from 7f9bdf3
file-service 82.16% <ø> (ø) Carriedforward from 7f9bdf3
frontend 96.45% <100.00%> (+<0.01%) ⬆️
notebook-migration-service 83.77% <ø> (ø) Carriedforward from 7f9bdf3
pyamber 98.38% <ø> (ø) Carriedforward from 7f9bdf3
result-service 85.71% <ø> (ø) Carriedforward from 7f9bdf3
workflow-compiling-service 78.30% <ø> (ø) Carriedforward from 7f9bdf3

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fix frontend Changes related to the frontend GUI release/v1.2 back porting to release/v1.2

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants