Skip to content

refactor(amber, v1.2): pass in a ScanFileResolver - #9565

Open
xuang7 wants to merge 2 commits into
apache:release/v1.2from
xuang7:backport/9316-scan-file-resolver-v1.2
Open

xuang7 wants to merge 2 commits into
apache:release/v1.2from
xuang7:backport/9316-scan-file-resolver-v1.2

Conversation

@xuang7

@xuang7 xuang7 commented Nov 20, 2026

Copy link
Copy Markdown
Contributor

What changes were proposed in this PR?

Backport of #9315 to release/v1.2, based on the release/v1.3 version (#9316). This branch has no ResourceAccess, so FileResolver checks dataset read access itself. The agent-service change is left out because it depends on a change that is not on this branch.

Any related issues, documentation, discussions?

Backport of #9315.

How was this PR tested?

FileResolverSpec, the scan source operator tests, the workflow compiler tests and the compile endpoint tests pass on this branch.

Was this PR authored or co-authored using generative AI tooling?

Generated-by: Claude Code (Claude Fable 5.2)

@github-actions github-actions Bot added engine dependencies Pull requests that update a dependency file common platform Non-amber Scala service paths labels Nov 20, 2026
@Xiao-zhen-Liu
Xiao-zhen-Liu self-requested a review November 20, 2026 04:21

@Xiao-zhen-Liu Xiao-zhen-Liu left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@github-actions

Copy link
Copy Markdown
Contributor

Automated Reviewer Suggestions

Based on the git blame history of the changed files, we recommend the following reviewers:

  • Contributors with relevant context: @Yicong-Huang, @aglinxinyuan, @mengw15
    You can notify them by mentioning @Yicong-Huang, @aglinxinyuan, @mengw15 in a comment.

@codecov-commenter

codecov-commenter commented Nov 20, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 64.00000% with 9 lines in your changes missing coverage. Please review.
✅ Project coverage is 55.09%. Comparing base (bc9c994) to head (1c3b1b9).
⚠️ Report is 2 commits behind head on release/v1.2.

Files with missing lines Patch % Lines
...g/apache/texera/amber/operator/TestOperators.scala 42.85% 3 Missing and 1 partial ⚠️
...ber/operator/source/scan/file/FileScanOpExec.scala 33.33% 2 Missing and 2 partials ⚠️
...pache/texera/amber/core/storage/FileResolver.scala 87.50% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@                Coverage Diff                 @@
##             release/v1.2    #9565      +/-   ##
==================================================
+ Coverage           53.64%   55.09%   +1.45%     
+ Complexity           2573     1482    -1091     
==================================================
  Files                1078      809     -269     
  Lines               42397    34206    -8191     
  Branches             4568     3452    -1116     
==================================================
- Hits                22745    18847    -3898     
+ Misses              18331    14449    -3882     
+ Partials             1321      910     -411     
Flag Coverage Δ *Carryforward flag
access-control-service 64.35% <ø> (ø)
agent-service 38.97% <ø> (ø) Carriedforward from 280b31e
amber 60.52% <57.14%> (+6.61%) ⬆️
computing-unit-managing-service 1.65% <ø> (ø)
config-service 56.06% <ø> (ø)
file-service 61.72% <ø> (ø)
frontend 47.40% <ø> (+0.03%) ⬆️ Carriedforward from 280b31e
pyamber 93.37% <ø> (ø) Carriedforward from 280b31e
python 90.93% <ø> (ø) Carriedforward from 280b31e
workflow-compiling-service 58.99% <100.00%> (+0.29%) ⬆️

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@xuang7
xuang7 enabled auto-merge November 20, 2026 05:08

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

common dependencies Pull requests that update a dependency file engine platform Non-amber Scala service paths

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants