Skip to content

fix(licensing, v1.2): replace the stock card cover image with a project-made SVG - #9559

Merged
xuang7 merged 1 commit into
apache:release/v1.2from
CaroFernando:backport/9302-v1.2
Nov 20, 2026
Merged

xuang7 merged 1 commit into
apache:release/v1.2from
CaroFernando:backport/9302-v1.2

Conversation

@CaroFernando

Copy link
Copy Markdown
Contributor

What changes were proposed in this PR?

Backport of #9302 to release/v1.2 for the 1.2.1 RC2.

Source: fd85b9d

Replaces frontend/src/assets/card_background.jpg, a stock image with no recorded source (TinEye matches it to a Shutterstock vector), with the project-made card_background.svg from #9302. The SVG carries the ASF license header, so no LICENSE entry is needed.

The cherry-pick conflicted because the code that uses the cover image is different on v1.2:

  • card-item.component.ts doesn't exist on v1.2. On v1.2 the dashboard cover comes from defaultCover in dataset-card-item.component.ts, so that now points at the .svg. It shows the image through <img> with object-fit: cover, like the main component, so the SVG's preserveAspectRatio="xMidYMid slice" crops it the same way.
  • browse-section.component.ts (Hub): only defaultBackground changes to the .svg. v1.2's surrounding fields are kept.
  • browse-section.component.spec.ts: the conflicting hunk only contains tests that exist on main. The v1.2 spec doesn't reference the image, so the file is unchanged.

After this change, nothing on the branch references card_background.jpg.

Any related issues, documentation, discussions?

Backport of #9302. Part of #8984. Independent of the #9220 (#9512) and #9269 (#9513) backports, which are already merged.

How was this PR tested?

cd frontend
yarn format:ci
yarn lint
yarn test --watch=false --include src/app/hub/component/browse-section/browse-section.component.spec.ts --include src/app/dashboard/component/user/dataset-card-item/dataset-card-item.component.spec.ts

All pass: 2 test files, 14 tests.

Was this PR authored or co-authored using generative AI tooling?

Generated-by: Claude Code (Claude Opus 5.5)

…ct-made SVG

Backport of apache#9302 to release/v1.2.

Conflict resolution:
- card-item.component.ts does not exist on v1.2. The dashboard cover on
  v1.2 comes from dataset-card-item.component.ts (defaultCover), which now
  points at the .svg instead.
- browse-section.component.ts: kept v1.2's surrounding fields and changed
  only defaultBackground to the .svg.
- browse-section.component.spec.ts: the conflicting hunk is main-only
  tests; the v1.2 spec does not reference the image, so it is unchanged.

(cherry picked from commit fd85b9d)

Co-authored-by: Meng Wang <mengw15@uci.edu>
@github-actions github-actions Bot added the frontend Changes related to the frontend GUI label Nov 19, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Automated Reviewer Suggestions

Based on the git blame history of the changed files, we recommend the following reviewers:

  • Contributors with relevant context: @xuang7, @Ma77Ball
    You can notify them by mentioning @xuang7, @Ma77Ball in a comment.

@codecov-commenter

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 53.64%. Comparing base (280b31e) to head (d41a8d3).

Additional details and impacted files
@@                Coverage Diff                 @@
##             release/v1.2    #9559      +/-   ##
==================================================
- Coverage           53.67%   53.64%   -0.04%     
  Complexity           2573     2573              
==================================================
  Files                1078     1078              
  Lines               42397    42397              
  Branches             4568     4568              
==================================================
- Hits                22756    22742      -14     
- Misses              18324    18338      +14     
  Partials             1317     1317              
Flag Coverage Δ *Carryforward flag
access-control-service 64.35% <ø> (ø) Carriedforward from 280b31e
agent-service 38.97% <ø> (ø) Carriedforward from 280b31e
amber 53.91% <ø> (ø) Carriedforward from 280b31e
computing-unit-managing-service 1.65% <ø> (ø) Carriedforward from 280b31e
config-service 56.06% <ø> (ø) Carriedforward from 280b31e
file-service 61.72% <ø> (ø) Carriedforward from 280b31e
frontend 47.34% <100.00%> (-0.07%) ⬇️
pyamber 93.37% <ø> (ø) Carriedforward from 280b31e
python 90.93% <ø> (ø) Carriedforward from 280b31e
workflow-compiling-service 58.69% <ø> (ø) Carriedforward from 280b31e

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@xuang7 xuang7 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@xuang7
xuang7 added this pull request to the merge queue Nov 20, 2026
Merged via the queue into apache:release/v1.2 with commit 8e1a3d1 Nov 20, 2026
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

frontend Changes related to the frontend GUI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants