Repository navigation
fix(licensing, v1.2): replace the stock card cover image with a project-made SVG - #9559
Merged
Merged
Conversation
…ct-made SVG Backport of apache#9302 to release/v1.2. Conflict resolution: - card-item.component.ts does not exist on v1.2. The dashboard cover on v1.2 comes from dataset-card-item.component.ts (defaultCover), which now points at the .svg instead. - browse-section.component.ts: kept v1.2's surrounding fields and changed only defaultBackground to the .svg. - browse-section.component.spec.ts: the conflicting hunk is main-only tests; the v1.2 spec does not reference the image, so it is unchanged. (cherry picked from commit fd85b9d) Co-authored-by: Meng Wang <mengw15@uci.edu>
Contributor
Automated Reviewer SuggestionsBased on the
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## release/v1.2 #9559 +/- ##
==================================================
- Coverage 53.67% 53.64% -0.04%
Complexity 2573 2573
==================================================
Files 1078 1078
Lines 42397 42397
Branches 4568 4568
==================================================
- Hits 22756 22742 -14
- Misses 18324 18338 +14
Partials 1317 1317
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this PR?
Backport of #9302 to
release/v1.2for the 1.2.1 RC2.Source: fd85b9d
Replaces
frontend/src/assets/card_background.jpg, a stock image with no recorded source (TinEye matches it to a Shutterstock vector), with the project-madecard_background.svgfrom #9302. The SVG carries the ASF license header, so noLICENSEentry is needed.The cherry-pick conflicted because the code that uses the cover image is different on v1.2:
card-item.component.tsdoesn't exist on v1.2. On v1.2 the dashboard cover comes fromdefaultCoverindataset-card-item.component.ts, so that now points at the.svg. It shows the image through<img>withobject-fit: cover, like the main component, so the SVG'spreserveAspectRatio="xMidYMid slice"crops it the same way.browse-section.component.ts(Hub): onlydefaultBackgroundchanges to the.svg. v1.2's surrounding fields are kept.browse-section.component.spec.ts: the conflicting hunk only contains tests that exist on main. The v1.2 spec doesn't reference the image, so the file is unchanged.After this change, nothing on the branch references
card_background.jpg.Any related issues, documentation, discussions?
Backport of #9302. Part of #8984. Independent of the #9220 (#9512) and #9269 (#9513) backports, which are already merged.
How was this PR tested?
All pass: 2 test files, 14 tests.
Was this PR authored or co-authored using generative AI tooling?
Generated-by: Claude Code (Claude Opus 5.5)