Repository navigation
test(frontend): share workspace spec fixtures - #9536
Open
aglinxinyuan wants to merge 1 commit into
Open
aglinxinyuan wants to merge 1 commit into
aglinxinyuan wants to merge 1 commit into
Conversation
Consolidate repeated TestBed setup, mock-reader, stream stub, and export scenario helpers across 7 frontend workspace unit-test specs (+1,355 / -2,116 lines) without altering production code or test assertions.
Contributor
Automated Reviewer SuggestionsBased on the
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #9536 +/- ##
============================================
- Coverage 91.57% 91.56% -0.01%
Complexity 5157 5157
============================================
Files 1300 1300
Lines 58092 58092
Branches 7615 7615
============================================
- Hits 53195 53194 -1
Misses 2959 2959
- Partials 1938 1939 +1
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this PR?
Consolidate repeated TestBed mounting, mock-reader, stream-stub, console-frame, and result-exportation fixtures across 7 Angular workspace unit-test specs under
frontend/src/app/workspace/(+1,355 / −2,116 lines) without modifying production code or test assertions:computing-unit-selection.component.spec.ts): ExtractscreateMetaStream,makeLockedPve,bootWithSelectedStream, unifiedbootWithMetadata/openEditModal/makeWarehousefixtures, and inline-edit helpers across all 214 cases.hugging-face-audio-upload.component.spec.ts,hugging-face-image-upload.component.spec.ts): Consolidates mock file-reader fixtures, media selection helpers, and clear/error assertions across the audio (30 cases) and image (46 cases) upload specs.result-exportation.component.spec.ts,workflow-result-export.service.spec.ts): Extracts dialog TestBed mounting, dataset/flag builders, operator setup, alert assertions, availability checks, and table-driven blocked/warning/error scenarios across the component (44 cases) and service (35 cases) specs.console-frame.component.spec.ts,port-property-edit-frame.component.spec.ts): Shares TestBed configuration, timing/scroll/click probes, and console entry fixtures inConsoleFrameComponent(51 cases), plus port graph stubs, property/display-name event emitters, and Quill editor Enter-commit helpers inPortPropertyEditFrameComponent(36 cases).Any related issues, documentation, discussions?
Closes #9535.
How was this PR tested?
Verified on Node 24 (
yarn-4.14.1.cjs install --immutable --inline-builds) after final commit1d46fcfa73:Observed result:
prettier-eslint --list-different,eslint, and both stricttsc --noEmitchecks exited0.node --max-old-space-size=8192 ./node_modules/@angular/cli/bin/ng.js test --watch=false --progress=false \ --include src/app/workspace/component/hugging-face-audio-upload/hugging-face-audio-upload.component.spec.ts \ --include src/app/workspace/component/hugging-face-image-upload/hugging-face-image-upload.component.spec.ts \ --include src/app/workspace/component/power-button/computing-unit-selection.component.spec.ts \ --include src/app/workspace/component/property-editor/port-property-edit-frame/port-property-edit-frame.component.spec.ts \ --include src/app/workspace/component/result-exportation/result-exportation.component.spec.ts \ --include src/app/workspace/component/result-panel/console-frame/console-frame.component.spec.ts \ --include src/app/workspace/service/workflow-result-export/workflow-result-export.service.spec.tsObserved result:
7test files passed (456passed,0failed,0skipped).node --max-old-space-size=8192 ./node_modules/@angular/cli/bin/ng.js test --watch=false --progress=falseObserved result:
255test files passed (7,387passed,1skipped inoperator-property-edit-frame.component.spec.ts,0failed).Was this PR authored or co-authored using generative AI tooling?
Generated-by: Antigravity (Gemini 4 Neon)