Skip to content

feat(ci): allow PMC to override merge queue - #9531

Merged
parshimers merged 1 commit into
apache:mainfrom
parshimers:imaxon/bypass2
Nov 19, 2026
Merged

parshimers merged 1 commit into
apache:mainfrom
parshimers:imaxon/bypass2

Conversation

@parshimers

Copy link
Copy Markdown
Member

What changes were proposed in this PR?

Add the PMC members who are active in GitHub as bypass actors for
the merge queue

Any related issues, documentation, discussions?

Closes #9530. Discussed in #9104

How was this PR tested?

It's not really possible to test locally, we'll have to see what
it does.

Was this PR authored or co-authored using generative AI tooling?

No. I asked Claude to do a survey of all the ASF projects that use
.asf.yaml and rulesets, to get ideas of what others do, but I wrote
the ruleset myself based on the one from Mahout.

@github-actions github-actions Bot added the ci changes related to CI label Nov 19, 2026
@github-actions

Copy link
Copy Markdown
Contributor

👋 Thanks for opening this pull request, @parshimers!

It looks like the pull request description doesn't quite follow our template yet:

  • The What changes were proposed in this PR? section is missing; please keep the template's headings.

Filling out the template helps reviewers understand and triage your contribution faster. Please edit the description to complete it. This message will disappear automatically once the template is followed.

You can find the template prompts by editing the description, or see CONTRIBUTING.md for the full contribution flow.

@github-actions

Copy link
Copy Markdown
Contributor

Automated Reviewer Suggestions

Based on the git blame history of the changed files, we recommend the following reviewers:

  • No candidates found from git blame history.

parshimers added a commit to parshimers/texera that referenced this pull request Nov 19, 2026
Add the PMC members who are active in GitHub as bypass actors for
the merge queue
@parshimers parshimers changed the title feat(ci): stop writes after upload failure (#9530) feat(ci): allow PMC to override merge queue (#9531) Nov 19, 2026
@codecov-commenter

codecov-commenter commented Nov 19, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.57%. Comparing base (4a9478c) to head (3e475ce).
⚠️ Report is 5 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #9531      +/-   ##
============================================
+ Coverage     91.55%   91.57%   +0.01%     
- Complexity     5132     5158      +26     
============================================
  Files          1293     1300       +7     
  Lines         57437    58092     +655     
  Branches       7507     7615     +108     
============================================
+ Hits          52584    53195     +611     
- Misses         2941     2959      +18     
- Partials       1912     1938      +26     
Flag Coverage Δ
access-control-service 77.44% <ø> (ø)
agent-service 99.56% <ø> (ø)
amber 85.43% <ø> (+0.12%) ⬆️
computing-unit-managing-service 63.88% <ø> (-0.15%) ⬇️
config-service 87.50% <ø> (ø)
file-service 82.16% <ø> (ø)
frontend 96.45% <ø> (+0.02%) ⬆️
notebook-migration-service 83.77% <ø> (ø)
pyamber 98.38% <ø> (+0.06%) ⬆️
result-service 85.71% <ø> (?)
workflow-compiling-service 78.30% <ø> (ø)

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@parshimers parshimers changed the title feat(ci): allow PMC to override merge queue (#9531) feat(ci): allow PMC to override merge queue Nov 19, 2026
@github-actions

github-actions Bot commented Nov 19, 2026 •

Copy link
Copy Markdown
Contributor

✅ No material benchmark regressions detected

🟢 1 better · 🔴 0 worse · ⚪ 14 noise (<±5%) · 0 without baseline

Compared against main 0aea3df benchmarked on this same runner, so the delta is largely free of cross-runner hardware noise. The "7d avg" column still reflects the gh-pages dashboard. Treat <±5% as noise unless repeated.

Dashboard · Run

config throughput MB/s latency max Δ latest / 7d
🟢 bs=10 sw=10 sl=64 415 0.253 22,697/35,859/35,859 us 🟢 -6.0% / 🔴 +179.9%
⚪ bs=100 sw=10 sl=64 856 0.522 113,211/135,324/135,324 us ⚪ within ±5% / 🔴 +65.4%
⚪ bs=1000 sw=10 sl=64 966 0.59 1,029,260/1,128,179/1,128,179 us ⚪ within ±5% / 🔴 +47.6%
Baseline details

Latest main 0aea3df from same runner

config metric PR latest main 7d avg Δ latest Δ 7d
bs=10 sw=10 sl=64 throughput 415 tuples/sec 406 tuples/sec 1,084 tuples/sec +2.2% -61.7%
bs=10 sw=10 sl=64 MB/s 0.253 MB/s 0.248 MB/s 0.662 MB/s +2.0% -61.8%
bs=10 sw=10 sl=64 p50 22,697 us 24,139 us 9,548 us -6.0% +137.7%
bs=10 sw=10 sl=64 p95 35,859 us 35,313 us 12,811 us +1.5% +179.9%
bs=10 sw=10 sl=64 p99 35,859 us 35,313 us 15,432 us +1.5% +132.4%
bs=100 sw=10 sl=64 throughput 856 tuples/sec 872 tuples/sec 1,467 tuples/sec -1.8% -41.7%
bs=100 sw=10 sl=64 MB/s 0.522 MB/s 0.532 MB/s 0.895 MB/s -1.9% -41.7%
bs=100 sw=10 sl=64 p50 113,211 us 112,076 us 74,441 us +1.0% +52.1%
bs=100 sw=10 sl=64 p95 135,324 us 139,987 us 81,800 us -3.3% +65.4%
bs=100 sw=10 sl=64 p99 135,324 us 139,987 us 103,712 us -3.3% +30.5%
bs=1000 sw=10 sl=64 throughput 966 tuples/sec 968 tuples/sec 1,517 tuples/sec -0.2% -36.3%
bs=1000 sw=10 sl=64 MB/s 0.59 MB/s 0.591 MB/s 0.926 MB/s -0.2% -36.3%
bs=1000 sw=10 sl=64 p50 1,029,260 us 1,024,997 us 725,911 us +0.4% +41.8%
bs=1000 sw=10 sl=64 p95 1,128,179 us 1,091,798 us 764,152 us +3.3% +47.6%
bs=1000 sw=10 sl=64 p99 1,128,179 us 1,091,798 us 808,901 us +3.3% +39.5%
Raw CSV
config_idx,batch_size,schema_width,string_len,num_batches,total_ms,total_tuples,total_bytes,tuples_per_sec,mb_per_sec,lat_p50_us,lat_p95_us,lat_p99_us
0,10,10,64,20,481.93,200,128000,415,0.253,22697.39,35859.40,35859.40
1,100,10,64,20,2336.70,2000,1280000,856,0.522,113211.39,135323.78,135323.78
2,1000,10,64,20,20700.00,20000,12800000,966,0.590,1029259.65,1128179.12,1128179.12

@aglinxinyuan aglinxinyuan left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment thread .asf.yaml Resolved
Add the PMC members who are active in GitHub as bypass actors for
the merge queue

@Yicong-Huang Yicong-Huang left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, let's quickly test it.

@parshimers
parshimers enabled auto-merge November 19, 2026 06:01
@parshimers
parshimers added this pull request to the merge queue Nov 19, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Nov 19, 2026
@parshimers
parshimers added this pull request to the merge queue Nov 19, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Nov 19, 2026
@parshimers
parshimers added this pull request to the merge queue Nov 19, 2026
Merged via the queue into apache:main with commit 4db10cf Nov 19, 2026
70 of 72 checks passed
@parshimers
parshimers deleted the imaxon/bypass2 branch November 19, 2026 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci changes related to CI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Allow PMC to bypass merge queue when necessary

4 participants