Repository navigation
fix(workflow-operator): one validation contract for the four legacy Hugging Face operators #9209
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
PG1204
wants to merge
4
commits into
apache:main
Choose a base branch
from
PG1204:fix/hf-legacy-schema-validation
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+346
−109
Open
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
9a959b4
fix(workflow-operator): one validation contract for the four legacy H…
PG1204 00cc7ee
Merge branch 'apache:main' into fix/hf-legacy-schema-validation
PG1204 10fe0bd
Merge branch 'apache:main' into fix/hf-legacy-schema-validation
PG1204 7ef67b6
Merge branch 'apache:main' into fix/hf-legacy-schema-validation
PG1204 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
67 changes: 67 additions & 0 deletions
67
...main/scala/org/apache/texera/amber/operator/huggingFace/HuggingFaceSchemaValidation.scala
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,67 @@ | ||
| /* | ||
| * Licensed to the Apache Software Foundation (ASF) under one | ||
| * or more contributor license agreements. See the NOTICE file | ||
| * distributed with this work for additional information | ||
| * regarding copyright ownership. The ASF licenses this file | ||
| * to you under the Apache License, Version 2.0 (the | ||
| * "License"); you may not use this file except in compliance | ||
| * with the License. You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, | ||
| * software distributed under the License is distributed on an | ||
| * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
| * KIND, either express or implied. See the License for the | ||
| * specific language governing permissions and limitations | ||
| * under the License. | ||
| */ | ||
|
|
||
| package org.apache.texera.amber.operator.huggingFace | ||
|
|
||
| import org.apache.texera.amber.core.tuple.{Attribute, AttributeType, Schema} | ||
|
|
||
| /** | ||
| * Configuration checks shared by the Spam Detection, Sentiment Analysis, Text | ||
| * Summarization and Iris Logistic Regression operators' `getOutputSchemas`. | ||
| * | ||
| * Each check throws. The compiler runs `getOutputSchemas` inside a `Try` and stores | ||
| * a thrown error on the operator's output port, which is how an operator that is | ||
| * not configured yet reports why. Messages name the field as the form shows it. | ||
| */ | ||
| private[huggingFace] object HuggingFaceSchemaValidation { | ||
|
|
||
| private val NUMERIC_TYPES = Set(AttributeType.INTEGER, AttributeType.LONG, AttributeType.DOUBLE) | ||
|
|
||
| /** Require a column-name field to be set and not blank. */ | ||
| def requireNonEmpty(fieldTitle: String, value: String): Unit = | ||
| if (value == null || value.trim.isEmpty) { | ||
| throw new RuntimeException(s"$fieldTitle cannot be empty") | ||
| } | ||
|
|
||
| /** | ||
| * Require the column a field names to be in the input table, spelled exactly as | ||
| * it is there: Schema lookups ignore case, but the generated Python does not. | ||
| */ | ||
| def requireInputColumn(schema: Schema, fieldTitle: String, column: String): Attribute = { | ||
| requireNonEmpty(fieldTitle, column) | ||
| schema.attributes | ||
| .find(_.getName == column) | ||
| .getOrElse( | ||
| throw new RuntimeException( | ||
| s"$fieldTitle '$column' is not in the input table. " + | ||
| s"Available columns: ${schema.getAttributeNames.mkString(", ")}" | ||
| ) | ||
| ) | ||
| } | ||
|
|
||
| /** As [[requireInputColumn]], and the column must also be numeric. */ | ||
| def requireNumericInputColumn(schema: Schema, fieldTitle: String, column: String): Unit = { | ||
| val columnType = requireInputColumn(schema, fieldTitle, column).getType | ||
| if (!NUMERIC_TYPES.contains(columnType)) { | ||
| throw new RuntimeException( | ||
| s"$fieldTitle '$column' must be numeric (integer, long or double), not ${columnType.getName}" | ||
| ) | ||
| } | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.