Skip to content

feat(frontend): explain the Kill button and where to find results and errors - #8771

Merged
Xiao-zhen-Liu merged 5 commits into
apache:mainfrom
sshiv012:sshiv012/tex-86-frontend-hints
Nov 7, 2026
Merged

Xiao-zhen-Liu merged 5 commits into
apache:mainfrom
sshiv012:sshiv012/tex-86-frontend-hints

Conversation

@sshiv012

@sshiv012 sshiv012 commented Sep 30, 2026 •

Copy link
Copy Markdown
Contributor

What changes were proposed in this PR?

Two small hints in the workspace:

  • Kill button tooltip: "Stop this run. A stopped run can't be resumed." It was an icon-only button with no explanation.
  • Empty Result panel: the heading now says why it is empty: "No operator is selected." or "This operator has no results yet." With nothing selected it also says "Click an operator to see its results. If a run fails, its errors show here." It always adds "Errors an operator hits while running show in that operator's Console." A failed run's errors only appear in the Static Error tab when nothing is selected, and errors during a run pause it and go to the operator's Console. Neither hint shows while previewing a workflow version.

Before and after, with nothing selected (top) and an operator selected (middle). The bottom row (a failed UDF showing its Static Error tab when clicked) is no longer part of this PR: on main that error still arrives as "unknown operator", because ControlError drops the worker that #8668 attaches. That will be fixed in the backend in a separate PR.

texera-8771-before-after-v2

The tooltip is a native title, which browsers don't draw in screenshots. I checked it in the running app: hovering the red button shows "Stop this run. A stopped run can't be resumed."

Any related issues, documentation, discussions?

Part of #8736. Split out of #8737.

How was this PR tested?

New specs in result-panel.component.spec.ts (nothing selected, an operator selected, version preview) and menu.component.spec.ts (the tooltip).

cd frontend
yarn test --include src/app/workspace/component/result-panel/result-panel.component.spec.ts --include src/app/workspace/component/menu/menu.component.spec.ts
yarn test
yarn format:ci

Was this PR authored or co-authored using generative AI tooling?

Generated-by: Claude Code (Claude Opus 5.5)

… errors

- Kill button: tooltip "Stop this run. A stopped run can't be resumed."
- Result panel empty state: say to click an operator for its results
  and Console, or an empty spot on the canvas for all operators' errors
  (the Static Error tab only appears when nothing is selected)

Refs TEX-86

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
(cherry picked from commit 94dff2f)
@github-actions github-actions Bot added the frontend Changes related to the frontend GUI label Sep 30, 2026
@github-actions

github-actions Bot commented Sep 30, 2026 •

Copy link
Copy Markdown
Contributor

Automated Reviewer Suggestions

Based on the git blame history of the changed files, we recommend the following reviewers:

  • Contributors with relevant context: @kz930, @xuang7, @yangzhang75
    You can notify them by mentioning @kz930, @xuang7, @yangzhang75 in a comment.

@sshiv012

sshiv012 commented Oct 2, 2026

Copy link
Copy Markdown
Contributor Author

/request-review @Xiao-zhen-Liu

@github-actions
github-actions Bot requested a review from Xiao-zhen-Liu October 2, 2026 20:27
- Errors an operator hits while running pause the run and show in its
  Console; the Static Error tab only appears when the run fails. Say
  that instead of "click an empty spot to see errors from all
  operators".
- Show "Click an operator..." only when nothing is selected, and no
  click hints while previewing a workflow version.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@sshiv012

sshiv012 commented Oct 8, 2026

Copy link
Copy Markdown
Contributor Author

Fixed: the selection hint disappears once an operator is selected, and both new hints are hidden during version preview.

@codecov-commenter

codecov-commenter commented Oct 8, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.33%. Comparing base (57faa6b) to head (f33c815).

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #8771   +/-   ##
=========================================
  Coverage     92.32%   92.33%           
- Complexity     5045     5048    +3     
=========================================
  Files          1260     1260           
  Lines         54026    54034    +8     
  Branches       6744     6746    +2     
=========================================
+ Hits          49879    49891   +12     
+ Misses         2487     2485    -2     
+ Partials       1660     1658    -2     
Flag Coverage Δ *Carryforward flag
access-control-service 77.38% <ø> (ø) Carriedforward from 45d201a
agent-service 99.16% <ø> (ø) Carriedforward from 45d201a
amber 87.33% <ø> (+0.02%) ⬆️ Carriedforward from 45d201a
computing-unit-managing-service 60.48% <ø> (ø) Carriedforward from 45d201a
config-service 87.37% <ø> (ø) Carriedforward from 45d201a
file-service 82.00% <ø> (ø) Carriedforward from 45d201a
frontend 96.54% <100.00%> (-0.01%) ⬇️
notebook-migration-service 83.73% <ø> (ø) Carriedforward from 45d201a
pyamber 98.57% <ø> (ø) Carriedforward from 45d201a
workflow-compiling-service 72.43% <ø> (ø) Carriedforward from 45d201a

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

…and say why the panel is empty

- A Python UDF that fails while starting reports its error from the
  coordinator, so the error says "unknown operator" and clicking the UDF
  showed only an empty Console. When an operator is selected, the
  Static Error tab now also shows errors that are not tied to any
  operator on the canvas (shared errorsForOperator filter used by the
  result panel and the error frame).
- The empty Result tab now says why it is empty: "No operator is
  selected." or "This operator has no results yet."

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
sshiv012 pushed a commit to sshiv012/texera that referenced this pull request Oct 15, 2026
- Result panel: the empty states now say "No operator is selected" or
  "This operator has no results yet"; clicking a failed box shows its
  Static Error tab (apache#8771).
- UDF guide: new rows for "does not implement <method>" and "does not
  subclass a pytexera base class", @OVERRIDES on a helper, the
  "(NameError at line 2 of the UDF code)" format, and "Columns" for
  1-out UDFs (apache#8768, apache#8769).
- Retake errors-all-operators.png with the final message, on a Texera
  built from all five code PRs on current main.

Refs apache#8736

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
sshiv012 and others added 2 commits October 16, 2026 15:06
…t panel

Showing errors that are not tied to any operator under whichever
operator is clicked is too broad. The startup error of a failed UDF
should instead carry the failing worker's operator id from the backend;
that fix will be a separate PR. This PR keeps the per-case empty-state
headings and hints.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@Xiao-zhen-Liu
Xiao-zhen-Liu added this pull request to the merge queue Oct 21, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to no response for status checks Oct 21, 2026
@Xiao-zhen-Liu
Xiao-zhen-Liu added this pull request to the merge queue Oct 22, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to no response for status checks Oct 22, 2026
@Xiao-zhen-Liu
Xiao-zhen-Liu added this pull request to the merge queue Nov 6, 2026
Merged via the queue into apache:main with commit d6c9050 Nov 7, 2026
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

frontend Changes related to the frontend GUI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants