Skip to content

fix(deps): bump brotli to 1.2.1 for scanners complaining about CVE-2026-111497 - #45743

Merged
hainenber merged 2 commits into
apache:masterfrom
MikolajBalcerek:fix/brotli-cve-2026-111497
Oct 27, 2026
Merged

hainenber merged 2 commits into
apache:masterfrom
MikolajBalcerek:fix/brotli-cve-2026-111497

Conversation

@MikolajBalcerek

@MikolajBalcerek MikolajBalcerek commented Oct 26, 2026 •

Copy link
Copy Markdown
Contributor

SUMMARY

Bump brotli to avoid scanners complaining about CVEs.

Brotli 1.0.3–1.2.0 has an out-of-bounds write in its decoder: CVE-2026-111497 (GHSA-9v8h-qqgm-4m35, PYSEC-2026-4322).

It is fixed in 1.2.1.

Superset pins brotli==1.2.0. Bumps the floor.

Exploitation looks very difficult to do, you need to make Superset make HTTP request to a server that sends poisoned response - exploitation not known in the wild any python stack yet.

Testing

  • In an installed environment: python -c "import brotli; print(brotli.__version__)" → 1.2.1.
  • I have added the same pin on top of the 6.1.0 envs and 7.0.0rc2 and didn't see a regression.

BTW

MikolajBalcerek and others added 2 commits October 26, 2026 17:24
Brotli 1.0.3-1.2.0 has an out-of-bounds write in the decoder
(CVE-2026-111497, PYSEC-2026-4322, GHSA-9v8h-qqgm-4m35). Superset pins
brotli==1.2.0; HTTP clients (requests, httpx, aiohttp, urllib3) use it to
decode `Content-Encoding: br` responses.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@MikolajBalcerek MikolajBalcerek changed the title fix(deps): bump brotli to 1.2.1 for CVE-2026-111497 fix(deps): bump brotli to 1.2.1 for scanners complaining about CVE-2026-111497 Oct 26, 2026
@codeant-ai-for-open-source

Copy link
Copy Markdown
Contributor

CodeAnt  CodeAnt PR Risk

🟢  Low Risk

  • The PR appears safe to merge; no actionable issues were identified in the review.

Assessed commit: c0ed60ddff09

@codecov

codecov Bot commented Oct 26, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 84.31%. Comparing base (09207d9) to head (c0ed60d).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #45743   +/-   ##
=======================================
  Coverage   84.31%   84.31%           
=======================================
  Files        3059     3059           
  Lines      202225   202225           
  Branches    47367    47367           
=======================================
  Hits       170516   170516           
  Misses      28451    28451           
  Partials     3258     3258           
Flag Coverage Δ
hive 34.77% <ø> (ø)
mysql 52.81% <ø> (ø)
postgres 52.82% <ø> (-0.01%) ⬇️
presto 36.50% <ø> (ø)
python 87.44% <ø> (ø)
sqlite 52.58% <ø> (ø)
unit 81.96% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@sha174n sha174n left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Verified the bump independently before approving:

  • brotli 1.2.1 (published 2026-10-22) ships manylinux and musllinux wheels for cp310 through cp315 on both x86_64 and aarch64, plus an sdist, so nothing in the support matrix falls back to a source build.
  • base.in and both lock files are consistent. Moving the floor rather than only the lock is what keeps the next pip-compile from reverting it.
  • No other brotli pin in the repo. The only other reference is superset-frontend/webpack.proxy-config.js, which is dev proxy tooling, and there is no brotlicffi.

On the reachability note in the description: agreed, and the inbound direction is worth stating explicitly for anyone triaging this downstream. brotli arrives via flask-compress, which compresses responses, and Werkzeug does not decompress request bodies, so there is no Content-Encoding: br request path into the decoder. The exposure is outbound: urllib3 2.x adds br to its default Accept-Encoding and decodes Brotli responses whenever the brotli package is importable, with no application code involved.

Two non-blocking notes:

  1. base.in line 27 now reads # Security: decompression bomb fix (required by aiohttp 3.13.3); CVE-2026-111497, but aiohttp is not in base.txt at this head. The only via entries under brotli==1.2.1 are -r requirements/base.in and flask-compress, so the aiohttp half of that comment looks stale.

  2. +1 on the pyarrow point, and apache/arrow#55166 is the right tracker. Separate change, and no reason to gate this one on it.

@hainenber
hainenber merged commit 86d54d9 into apache:master Oct 27, 2026
107 checks passed
villebro pushed a commit that referenced this pull request Oct 30, 2026
…26-111497 (#45743)

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
(cherry picked from commit 86d54d9)
@MikolajBalcerek

Copy link
Copy Markdown
Contributor Author

Pyarrow vendors its own brotli and they released a new version - #46018 bump for pyarrow

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants