fix(helm): add MCP HTTPRoute configuration

[dmunozv04]

SUMMARY

#41073 introduced HTTPRoute support for the helm chart, but it didn't include a rule for the MCP deployment.

PS: I'll try to make this one be my last PR in regards to the helm chart.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

N/A

TESTING INSTRUCTIONS

When #42206 is merged, helm-unittest will run on CI.

Alternatively, it can be tested by deploying the chart with the following values:

supersetMcp:
  enabled: true
  httproute:
    enabled: true

ADDITIONAL INFORMATION

• Has associated issue:
• Required feature flags:
• Changes UI
• Includes DB Migration (follow approval process in SIP-59)
  • Migration is atomic, supports rollback & is backwards-compatible
  • Confirm DB migration upgrade and downgrade tested
  • Runtime estimates and downtime expectations provided
• Introduces new feature or API
• Removes existing feature or API

[bito-code-review]

Code Review Agent Run #fb94a9

Actionable Suggestions - 1

• helm/superset/tests/httproute_test.yaml - 1

  • Missing rule count assertion · Line 65-79

Additional Suggestions - 1

• helm/superset/tests/httproute_test.yaml - 1

  • Missing combined feature test · Line 65-65
    No test exists for the combined scenario where both websockets and MCP are simultaneously enabled. Without this coverage, the rule ordering at lines 71-94 (websocket before MCP) is never validated in combination.

Review Details

• Files reviewed - 4 · Commit Range: c552f42..c552f42

  • helm/superset/Chart.yaml
  • helm/superset/templates/httproute.yaml
  • helm/superset/tests/httproute_test.yaml
  • helm/superset/values.yaml
• Files skipped - 1

  • helm/superset/README.md - Reason: Filter setting
• Tools

  • Whispers (Secret Scanner) - ✔︎ Successful
  • Detect-secrets (Secret Scanner) - ✔︎ Successful

---

Bito Usage Guide

Commands

Type the following command in the pull request comment and save the comment.

• /review - Manually triggers a full AI review.

• /pause - Pauses automatic reviews on this pull request.

• /resume - Resumes automatic reviews.

• /resolve - Marks all Bito-posted review comments as resolved.

• /abort - Cancels all in-progress reviews.

Refer to the documentation for additional commands.

Configuration

This repository uses Superset You can customize the agent settings here or contact your Bito workspace admin at evan@preset.io.

Documentation & Help

• Customize agent settings
• Review rules
• General documentation
• FAQ

AI Code Review powered by

[bito-code-review]

Missing rule count assertion

The MCP test lacks a rule count assertion. Without it, the test passes even if unexpected extra rules exist. This test should mirror the pattern used in the WebSocket test (lines 43-45) which explicitly asserts count: 2.

Code Review Run #fb94a9

---

Should Bito avoid suggestions like this for future reviews? (Manage Rules)

• Yes, avoid them

[rusackas]

Thanks @dmunozv04, this mirrors the websocket rule pattern nicely and the port/path all check out. Bito's flagging a missing rule-count assertion on the new MCP test in httproute_test.yaml (around line 65), might be worth adding a lengthEqual check there like the websocket test above it has. LGTM otherwise.