chore(lint): toggle import/no-named-as-default to error level + fix all violations

[hainenber]

chore(lint): toggle import/no-named-as-default to error level + fix all violations

SUMMARY

Continuation of usual house cleaning ops.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

N/A

TESTING INSTRUCTIONS

Green CI as acceptance threshold

ADDITIONAL INFORMATION

• Has associated issue:
• Required feature flags:
• Changes UI
• Includes DB Migration (follow approval process in SIP-59)
  • Migration is atomic, supports rollback & is backwards-compatible
  • Confirm DB migration upgrade and downgrade tested
  • Runtime estimates and downtime expectations provided
• Introduces new feature or API
• Removes existing feature or API

[bito-code-review]

AI Code Review is in progress (usually takes 3 to 15 minutes unless it's a very large PR).

[bito-code-review]

The security concern regarding reverse-tabnabbing is valid. When using markdown-to-jsx to render raw HTML anchors with target="_blank", the browser does not automatically restrict the window.opener property, which can be exploited by a malicious linked site. To resolve this, you should ensure all external links with target="_blank" include rel="noopener noreferrer".

Since markdown-to-jsx allows overriding components, you can globally enforce this by providing an override for the a tag in your MarkdownToJsx configuration:

<MarkdownToJsx
  options={{
    overrides: {
      a: {
        props: {
          target: '_blank',
          rel: 'noopener noreferrer',
        },
      },
    },
  }}
>
  {markdownContent}
</MarkdownToJsx>

Alternatively, if you prefer to update the markdown content directly, you can manually add the rel attribute to the anchor tags: <a href="..." target="_blank" rel="noopener noreferrer">...</a>.

Regarding other comments on this PR, the provided comment file is empty, so there are no additional suggestions to address.

superset-frontend/packages/superset-ui-core/src/components/DesignSystem.stories.tsx

<MarkdownToJsx
  options={{
    overrides: {
      a: {
        props: {
          target: '_blank',
          rel: 'noopener noreferrer',
        },
      },
    },
  }}
>
  {markdownContent}
</MarkdownToJsx>

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 65.18%. Comparing base (42a2aed) to head (1249a15).

Additional details and impacted files

@@            Coverage Diff             @@
##           master   #42214      +/-   ##
==========================================
- Coverage   65.19%   65.18%   -0.01%     
==========================================
  Files        2768     2768              
  Lines      156081   156081              
  Branches    35719    35719              
==========================================
- Hits       101754   101748       -6     
- Misses      52365    52371       +6     
  Partials     1962     1962              

Flag	Coverage Δ
javascript	70.82% <100.00%> (-0.01%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[bito-code-review]

Code Review Agent Run #44457d

Actionable Suggestions - 0

Additional Suggestions - 4

• superset-frontend/src/dashboard/components/SliceHeader/index.tsx - 2

  • Misleading import names · Line 47-48
    Import names `MemoizedFiltersBadge` and `MemoizedCustomizationsBadge` suggest these are memoized variants, but the source modules (`FiltersBadge/index.tsx`, `CustomizationsBadge/index.tsx`) only export default `memo(FiltersBadge)` and `memo(CustomizationsBadge)`. The `Memoized*` names are misleading as these are not separate memoized exports.
  • Redundant memoization · Line 336-336
    Components at lines 336 and 340 use `MemoizedCustomizationsBadge` and `MemoizedFiltersBadge` which are misleading names - the actual components are `CustomizationsBadge` and `FiltersBadge` (already memoized at definition). Consider using the original names for clarity.
• superset-frontend/plugins/plugin-chart-table/src/index.ts - 2

  • CWE-N: Naming Inconsistency · Line 31-31
    The import variable `cachedBuildQueryInstance` uses an inconsistent naming convention compared to all other chart plugins (e.g., `plugin-chart-echarts/src/Pie/index.ts` line 21). Other plugins import the buildQuery module simply as `buildQuery`, creating a misleading semantic gap where the variable name suggests caching behavior not reflected in the property usage.
  • Inconsistent property assignment · Line 79-79
    The property assignment uses explicit aliasing `buildQuery: cachedBuildQueryInstance` which requires extra mental tracking—the variable name doesn't match the property name. Other chart plugins in this codebase use the shorter `buildQuery,` form when the import and property names are the same.

Review Details

• Files reviewed - 13 · Commit Range: 2f7c72c..1249a15

  • superset-frontend/packages/superset-ui-core/src/components/DesignSystem.stories.tsx
  • superset-frontend/packages/superset-ui-core/src/components/DropdownContainer/Overview.stories.tsx
  • superset-frontend/packages/superset-ui-core/src/components/MetadataBar/MetadataBarOverview.stories.tsx
  • superset-frontend/packages/superset-ui-core/src/components/Table/TableOverview.stories.tsx
  • superset-frontend/packages/superset-ui-core/src/components/Table/cell-renderers/ActionCell/ActionCell.overview.tsx
  • superset-frontend/packages/superset-ui-switchboard/src/index.ts
  • superset-frontend/plugins/plugin-chart-table/src/index.ts
  • superset-frontend/plugins/plugin-chart-table/test/buildQuery.test.ts
  • superset-frontend/src/dashboard/components/SliceHeader/index.tsx
  • superset-frontend/src/dashboard/components/nativeFilters/FilterBar/FilterBarSettings/index.tsx
  • superset-frontend/src/dashboard/components/nativeFilters/FilterBar/FilterConfigurationLink/FilterConfigurationLink.test.tsx
  • superset-frontend/src/pages/Home/index.tsx
  • superset-frontend/src/views/App.tsx
• Files skipped - 1

  • superset-frontend/oxlint.json - Reason: Filter setting
• Tools

  • Whispers (Secret Scanner) - ✔︎ Successful
  • Detect-secrets (Secret Scanner) - ✔︎ Successful
  • Eslint (Linter) - ✔︎ Successful

---

Bito Usage Guide

Commands

Type the following command in the pull request comment and save the comment.

• /review - Manually triggers a full AI review.

• /pause - Pauses automatic reviews on this pull request.

• /resume - Resumes automatic reviews.

• /resolve - Marks all Bito-posted review comments as resolved.

• /abort - Cancels all in-progress reviews.

Refer to the documentation for additional commands.

Configuration

This repository uses Superset You can customize the agent settings here or contact your Bito workspace admin at evan@preset.io.

Documentation & Help

• Customize agent settings
• Review rules
• General documentation
• FAQ

AI Code Review powered by

[rusackas]

Thanks @hainenber, LGTM! Always nice to see another one of these lint TODOs knocked out. Approving, and will merge soon if there's no objection.