Draft
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #39887 +/- ##
==========================================
- Coverage 64.36% 64.36% -0.01%
==========================================
Files 2569 2569
Lines 134745 134751 +6
Branches 31278 31279 +1
==========================================
+ Hits 86731 86734 +3
- Misses 46516 46519 +3
Partials 1498 1498
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SUMMARY
Adds an optional
color_schemefield to the MCPXYChartConfigandPieChartConfigso LLM clients can pick a Superset color palette when generating charts. Pie's hardcoded"supersetColors"is now an overridable default; XY had no color control before. Wired throughmap_xy_config(via a newadd_color_schemehelper to keep it under the C901 complexitylimit) and
map_pie_config.Example:
{ "dataset_id": 1, "config": { "chart_type": "xy", "x": {"name": "ds"}, "y": [{"name": "val", "aggregate": "SUM"}], "kind": "line", "color_scheme": "lyftColors" } }This is a minimal first slice of broader MCP chart-formatting work (number/date format, axis/data labels, dashboard-level metric color overrides) — those will follow in separate PRs.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
pass).
default applies).
ADDITIONAL INFORMATION