Skip to content

[SPARK-57964][PYSPARK] Fix DataFrame.dropna VALUE_NOT_ANY_OR_ALL parameter name mismatch #57135

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
marcuslin123 wants to merge 2 commits into from
Closed

[SPARK-57964][PYSPARK] Fix DataFrame.dropna VALUE_NOT_ANY_OR_ALL parameter name mismatch #57135

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
37c68b8
[SPARK-57964][PYSPARK] Fix DataFrame.dropna VALUE_NOT_ANY_OR_ALL para…
Jul 8, 2026
a935860
Fix Connect dropna to use VALUE_NOT_ANY_OR_ALL (consistent with class…
Jul 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion python/pyspark/sql/classic/dataframe.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1356,7 +1356,7 @@ def dropna(
if how is not None and how not in ["any", "all"]:
raise PySparkValueError(
errorClass="VALUE_NOT_ANY_OR_ALL",
messageParameters={"arg_name": "how", "arg_type": how},
messageParameters={"arg_name": "how", "arg_value": how},
)

if subset is None:
Expand Down
2 changes: 1 addition & 1 deletion python/pyspark/sql/connect/dataframe.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1394,7 +1394,7 @@ def dropna(
min_non_nulls = None
else:
raise PySparkValueError(
errorClass="CANNOT_BE_EMPTY",
errorClass="VALUE_NOT_ANY_OR_ALL",
messageParameters={"arg_name": "how", "arg_value": str(how)},
)

Expand Down
11 changes: 11 additions & 0 deletions python/pyspark/sql/tests/test_stat.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@
from pyspark.errors import (
AnalysisException,
PySparkTypeError,
PySparkValueError,
)
from pyspark.testing.sqlutils import ReusedSQLTestCase

Expand Down Expand Up @@ -127,6 +128,16 @@ def test_dropna(self):
},
)

# Regression test: invalid 'how' should raise PySparkValueError, not AssertionError

@zhengruifeng zhengruifeng Jul 9, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what does the 'not AssertionError' here mean?

@marcuslin123 marcuslin123 Jul 9, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Before this fix, invalid 'how' values would raise an AssertionError instead of the intended PySparkValueError.

with self.assertRaises(PySparkValueError) as pe:
self.spark.createDataFrame([("Alice", 50, 80.1)], schema).dropna(how="foo")

self.check_error(
exception=pe.exception,
errorClass="VALUE_NOT_ANY_OR_ALL",
messageParameters={"arg_name": "how", "arg_value": "foo"},
)

def test_fillna(self):
schema = StructType(
[
Expand Down