Skip to content

[SPARK-54770][PYTHON] Replace dead assert with proper error in _create_converter #56051

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
shrirangmhalgi wants to merge 1 commit into
base: master
Choose a base branch
from
+2 −2
Open

[SPARK-54770][PYTHON] Replace dead assert with proper error in _create_converter #56051

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions python/pyspark/sql/conversion.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -891,8 +891,8 @@ def convert_other(value: Any) -> Any:
return value

return convert_other
else: # pragma: no cover
assert False, f"Need converter for {dataType} but failed to find one."

assert False, f"_need_converter returned True for {dataType} but no converter was created."

@staticmethod
def convert(data: Sequence[Any], schema: StructType, use_large_var_types: bool) -> "pa.Table":
Expand Down