[SPARK-56643][SPARK-56619][CONNECT][SQL][TESTS] Share DSv2 test cases…#56047
Open
longvu-db wants to merge 1 commit into
Open
[SPARK-56643][SPARK-56619][CONNECT][SQL][TESTS] Share DSv2 test cases…#56047longvu-db wants to merge 1 commit into
longvu-db wants to merge 1 commit into
Conversation
… between classic and connect Refactors DSv2 test organization to eliminate duplication between classic and Connect mode tests. Introduces shared test traits that define test scenarios once and run them in both modes. New shared traits in sql/core (accessible from both sql/core and sql/connect): - DSv2ExternalMutationTestBase: base trait with 5 abstract methods (withTestSession, checkRows, getTableCatalog, withTestTableAndViews, testPrefix) and shared externalAppend helper - DSv2TempViewWithStoredPlanTests: 21 temp view tests (7 scenarios x 3 variants) - DSv2RepeatedSQLTests: 9 repeated sql() access tests (3 scenarios x 3 variants) Classic suite (DataSourceV2DataFrameSuite): - Mixes in DSv2TempViewWithStoredPlanTests and DSv2RepeatedSQLTests - Implements abstract methods using classic session, checkAnswer, catalog() - Removes 578 lines of inline test code Connect suites (thin wrappers): - DataSourceV2TempViewConnectSuite (72 lines vs 739 previously) - DataSourceV2RepeatedSQLConnectSuite (144 lines, includes 3 connect-specific "reused DataFrame" tests) Co-authored-by: Isaac
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… between classic and connect
Refactors DSv2 test organization to eliminate duplication between classic and Connect mode tests. Introduces shared test traits that define test scenarios once and run them in both modes.
New shared traits in sql/core (accessible from both sql/core and sql/connect):
Classic suite (DataSourceV2DataFrameSuite):
Connect suites (thin wrappers):
Co-authored-by: Isaac
What changes were proposed in this pull request?
Why are the changes needed?
Does this PR introduce any user-facing change?
How was this patch tested?
Was this patch authored or co-authored using generative AI tooling?