[SPARK-56954][PYTHON] Annotate that we support MapType for from_json#55997
Closed
gaogaotiantian wants to merge 2 commits into
Closed
[SPARK-56954][PYTHON] Annotate that we support MapType for from_json#55997gaogaotiantian wants to merge 2 commits into
gaogaotiantian wants to merge 2 commits into
Conversation
Co-authored-by: Isaac
zhengruifeng
approved these changes
May 21, 2026
zhengruifeng
pushed a commit
that referenced
this pull request
May 21, 2026
### What changes were proposed in this pull request? * Add annotation for `from_json` that we support `MapType` as schema input. * Clean up the docs so it's consistent. * Add a test for `MapType`. ### Why are the changes needed? We already supported the feature, just need the annotation so it's clear to the users and also type checkers won't complaint. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? CI for both lint and new test. ### Was this patch authored or co-authored using generative AI tooling? No. Closes #55997 from gaogaotiantian/from-json-map-type. Authored-by: Tian Gao <gaogaotiantian@hotmail.com> Signed-off-by: Ruifeng Zheng <ruifengz@foxmail.com> (cherry picked from commit 2ffd11d) Signed-off-by: Ruifeng Zheng <ruifengz@foxmail.com>
Contributor
|
merged to master/4.x |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
from_jsonthat we supportMapTypeas schema input.MapType.Why are the changes needed?
We already supported the feature, just need the annotation so it's clear to the users and also type checkers won't complaint.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
CI for both lint and new test.
Was this patch authored or co-authored using generative AI tooling?
No.