Repository navigation
Conversation
PsiACE
approved these changes
Nov 20, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #975.
Direct cryptographic implementation dependencies now live only under
crypto/*. The seven inherited raw dependencies (aes-gcm,getrandom,hmac,p256,rsa,sha1,sha2) are declared directly byreqsign-crypto-rustcryptoinstead of the root workspace, and the service test suites use fixed synthetic fixtures plus recording providers instead of runtime key generation and direct backend verification.The service tests still check the protocol-level behavior independently: canonical signing inputs, PKCS#1/PKCS#8 and LF/CRLF PEM handling, encrypted-PEM and public-key rejection, fixed RS256 JWT vectors, AWS SigV4a scalar derivation and DER-hex wrapping, and Tink CAB key/nonce/AAD/plaintext plus protobuf and wire framing. Backend algorithm correctness remains covered by the provider crates.
A manifest check now rejects direct cryptographic implementation crates outside
crypto/*in normal, dev, and build dependency kinds, including renamed packages, target-specific tables, and unused root[workspace.dependencies]entries. The existing resolved production graph check remains in place.docs/crypto-provider.mddocuments the stricter boundary.Validation on the PR head:
cargo fmt --all -- --checkcargo clippy --workspace --all-targets --all-features -- -D warningscargo test --no-fail-fastRUSTDOCFLAGS='--cfg docsrs' cargo +nightly test --doc --all-features --workspacecargo +1.87.0 check --workspace --all-targets --all-featureshawkeye checkcargo tree --all-features --target all --edges normalgate