NO-JIRA: [Python] Fix exception in IOHandler.on_selectable_expired/update#364
Open
Jmennius wants to merge 1 commit intoapache:mainfrom
Open
Conversation
Contributor
Author
|
Here is a traceback: |
Codecov Report
@@ Coverage Diff @@
## main #364 +/- ##
===========================================
+ Coverage 68.24% 88.36% +20.11%
===========================================
Files 367 47 -320
Lines 73285 2397 -70888
===========================================
- Hits 50011 2118 -47893
+ Misses 23274 279 -22995 Continue to review full report at Codecov.
|
Contributor
Author
|
@astitcher What do you think? |
…date This occasionally happens after my laptop wakes up from overnight sleep. IOHandler.on_selectable_expired() is invoked with `selectable` that has `_terminated=True` and `_transport=None` so when `IOHandler.update()` is called it crashes when trying to handle the exception (since transport is None). Fix this by checking if transport attribute is set and that selectable is not terminated before invoking `IOHandler.update()`. Signed-off-by: Ievgen Popovych <ievgenp@seetrue.ai>
4d22a80 to
8b75942
Compare
|
Could we get this PR merged? I ran into the bug recently. It causes qpid proton to be pretty unusable. |
Contributor
Author
|
I've opened a Jira issue for this https://issues.apache.org/jira/browse/PROTON-2776. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This occasionally happens after my laptop wakes up from overnight sleep.
IOHandler.on_selectable_expired()is invoked withselectablethat has_terminated=Trueand_transport=Noneso whenIOHandler.update()is called it crashes when trying to handle the exception
(since transport is None).
Fix this by checking if transport attribute is set and that selectable is not
terminated before invoking
IOHandler.update().PROTON Jira issue: https://issues.apache.org/jira/browse/PROTON-2776