Skip to content

QPIDJMS-617: BytesMessage increments the read pointer position on MessageFormatException #56

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tabish121 merged 2 commits into from
Jan 6, 2026
Merged

QPIDJMS-617: BytesMessage increments the read pointer position on MessageFormatException #56

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a0a8fae
QPIDJMS-617: BytesMessage increments the read pointer position on Mes…
dakirily Dec 29, 2025
88417df
QPIDJMS-617: BytesMessage increments the read pointer position on Mes…
Jan 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions qpid-jms-client/src/main/java/org/apache/qpid/jms/message/JmsBytesMessage.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -200,11 +200,22 @@ public double readDouble() throws JMSException {
@Override
public String readUTF() throws JMSException {
initializeReading();
final boolean canReset = this.dataIn.markSupported();
if (canReset) {
this.dataIn.mark(Integer.MAX_VALUE);
}
try {
return this.dataIn.readUTF();
} catch (EOFException e) {
throw JmsExceptionSupport.createMessageEOFException(e);
} catch (IOException e) {
if (canReset) {
try {
this.dataIn.reset();
} catch (IOException ignored) {
// if reset fails original failure should be propagated
}
}
throw JmsExceptionSupport.createMessageFormatException(e);
}
}
Expand Down
17 changes: 17 additions & 0 deletions qpid-jms-client/src/test/java/org/apache/qpid/jms/message/JmsBytesMessageTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -438,6 +438,23 @@ public void testReadUTF() throws JMSException {
assertTrue(msg.readUTF().equals(str));
}

@Test
public void testReadUTFMessageFormatExceptionDoesNotAdvanceReadPointer() throws Exception {
JmsBytesMessage msg = factory.createBytesMessage();
msg.writeShort((short) 2);
msg.writeByte((byte) 0xC0);
msg.writeByte((byte) 0x00);
msg.reset();

assertThrows(MessageFormatException.class, msg::readUTF);

assertEquals(2, msg.readUnsignedShort());
assertEquals((byte) 0xC0, msg.readByte());
assertEquals((byte) 0x00, msg.readByte());

assertThrows(MessageEOFException.class, msg::readByte);
}

@Test
public void testReadBytesbyteArray() throws JMSException {
JmsBytesMessage msg = factory.createBytesMessage();
Expand Down