Skip to content

Address the R2_LOCAL_SIGNING review follow-ups - #6147

Open
deepdishgary wants to merge 1 commit into
apache:mainfrom
deepdishgary:r2/3-review-follow-ups
Open

deepdishgary wants to merge 1 commit into
apache:mainfrom
deepdishgary:r2/3-review-follow-ups

Conversation

@deepdishgary

Copy link
Copy Markdown
Contributor

Follow-up to #5972. It makes the small changes that the reviews of that PR asked for and that I deferred so the approvals stayed valid.

  • R2_LOCAL_SIGNING catalogs now accept kmsUnavailable=true. R2 has no KMS and the integration never reads the flag, so the refusal only blocked a correct setting. stsUnavailable=true is still refused, because it makes the access delegation resolver fall back to remote signing. New tests cover validate, catalog create, and vending with the flag set.
  • The changelog fragment says "S3-compatible storage that uses an R2 endpoint", as suggested in review.
  • The fragment no longer says that every realm shares one parent token. The tokens are server-wide, and a catalog's storageName selects a named token when RESOLVE_CREDENTIALS_BY_STORAGE_NAME is true.
  • Javadoc: the rule about the checks that run again at vend time and the empty path segment rule are each explained once, where they are enforced. The other places link to them.

Checklist

  • 🛡️ Don't disclose security issues! (contact security@apache.org)
  • 🔗 Clearly explained why the changes are needed, or linked related issues: Fixes #
  • 🧪 Added/updated tests with good coverage, or manually tested (and explained how)
  • 💡 Added comments for complex logic
  • 🧾 Added a changelog entry in changelog.d/ (if needed, see changelog.d/README.md)
  • 📚 Updated documentation in site/content/in-dev/unreleased (if needed)

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant