Repository navigation
Address the R2_LOCAL_SIGNING review follow-ups - #6147
Open
deepdishgary wants to merge 1 commit into
Open
deepdishgary wants to merge 1 commit into
deepdishgary wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #5972. It makes the small changes that the reviews of that PR asked for and that I deferred so the approvals stayed valid.
R2_LOCAL_SIGNINGcatalogs now acceptkmsUnavailable=true. R2 has no KMS and the integration never reads the flag, so the refusal only blocked a correct setting.stsUnavailable=trueis still refused, because it makes the access delegation resolver fall back to remote signing. New tests cover validate, catalog create, and vending with the flag set.storageNameselects a named token whenRESOLVE_CREDENTIALS_BY_STORAGE_NAMEis true.Checklist
changelog.d/(if needed, seechangelog.d/README.md)site/content/in-dev/unreleased(if needed)