Repository navigation
Conversation
Keep ECS role URNs unchanged in STS AssumeRole requests while using arn:aws:s3::: for S3 session policy resources. Add a regression test and document the ECS-specific ARN handling. Related to apache#2743
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix S3 credential vending for Dell ECS, which requires different identifier formats for STS roles and S3 policy resources.
Dell ECS uses role URNs such as
urn:ecs:iam::namespace:role/s3assumeRole. Polaris currently derives the S3 policy partition from that identifier, producing resources such asarn:ecs:s3:::bucket/path/*. ECS rejects these resources because it expectsarn:aws:s3:::instead.Changes
arn:aws:s3:::for S3 inline session policy resources when the configured role identifier starts withurn:ecs:.No new configuration options or public API changes are introduced.
Testing
./gradlew format compileAll check.testGetSubscopedCredsEcsInlinePolicyto verify that:PURGEand verified deletion of the corresponding metadata and data files.AI assistance
AI assistance was used to prepare the implementation, regression test, documentation, and PR description.
Checklist
changelog.d/(if needed, seechangelog.d/README.md)site/content/in-dev/unreleased(if needed)Related to #2743