Repository navigation
Conversation
There was a problem hiding this comment.
Warning
Copilot couldn't run its full agentic review because it didn't start before the timeout. Make sure your repository has a runner available, or add a copilot-code-review.yml file specifying one with the runs-on attribute. See the docs for more details.
Copilot review overview
2 open findings
What changed in this PR
Adds Develocity Docker Build Scan publishing to the Docker image build in CI, so BuildKit step timing/cache/log/package info is captured in develocity.apache.org.
Changes:
- Adds a
Setup Dockerstep usinggradle/develocity-actions/setup-dockerto run the Develocity Docker build agent during the image build. - Configures the agent to publish scans to
develocity.apache.orgunder thepolarisproject usingDEVELOCITY_ACCESS_KEY.
| File | Description |
|---|---|
| .github/workflows/ci.yml | Adds Develocity Docker agent setup before the image build so Docker Build Scans can be published. |
🧠 Review effort: Lite
Give feedback about Copilot approvals in this survey to enter a drawing for a $150 gift card.
| - name: Setup Docker | ||
| uses: gradle/develocity-actions/setup-docker@f852d93dada312948b1ba533226c28e05d756866 # v2.4 | ||
| with: | ||
| develocity-url: https://develocity.apache.org | ||
| develocity-access-key: ${{ secrets.DEVELOCITY_ACCESS_KEY }} # zizmor: ignore[secrets-outside-env] | ||
| develocity-project-id: polaris |
There was a problem hiding this comment.
Fixed. The step now runs only on branch builds of apache/polaris.
| uses: gradle/develocity-actions/setup-docker@f852d93dada312948b1ba533226c28e05d756866 # v2.4 | ||
| with: | ||
| develocity-url: https://develocity.apache.org | ||
| develocity-access-key: ${{ secrets.DEVELOCITY_ACCESS_KEY }} # zizmor: ignore[secrets-outside-env] |
There was a problem hiding this comment.
The fix the audit suggests is a deployment environment. That would cover every job that uses this secret, so it belongs in its own change.
|
Thanks for your contribution, @donat ! Polaris uses Quarkus for building the docker image. So we do not have much control over the internals of that process. I wonder whether publishing those docker scans is useful for Polaris CI 🤔 |
|
This PR is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days. |
|
Hi @dimas-b! This is the first public release of the Docker build scan agent. It may not be useful in the current form. However, we need feedback on i) whether the data collected is already useful and ii) what features are missing that would make it valuable for you and for users at large. |
|
I’m still missing a concrete Polaris use case for this integration. What issue in our image build would these scans help diagnose, and what actionable information would they provide beyond the existing logs and Gradle scans? The lack of scans for PR builds also limits the usefulness for reviewing changes. Additionally, the setup step runs unconditionally, so those builds still download and start the agent even though they cannot publish a scan. What is the measured overhead, including package scanning and cleanup, and could setup be skipped when publishing is unavailable? With limited review capacity, I’d like to see a demonstrated benefit to Polaris beyond the existing Gradle build scans and a clear understanding of the ongoing CI cost before prioritizing this integration. |
|
Hi @donat !
My point is that I am not sure the changes in this PR actually connect with the Quarkus build action that produces Polaris docker images. Were you able to get any scans published with this change? Could you share links to them? |
666e0e8 to
a7886d5
Compare
orca-review-bot
left a comment
There was a problem hiding this comment.
Small CI-only change. The guard keeps the secret away from PR runs: ci-pr.yml doesn't pass DEVELOCITY_ACCESS_KEY, and the refs/heads/ check skips refs/pull/.... The action is SHA-pinned. A few small asks are inline.
Not anchored to a line:
- Can we update the
DEVELOCITY_ACCESS_KEYrow in.github/SECRETS.mdso it mentions the Docker image scans too? - Two questions from the thread are still open. snazy asked how much overhead the agent adds to the job, including package scanning and cleanup. dimas-b asked whether the agent actually sees the Quarkus-driven image build in CI. A link to a real scan from a branch run, or a before/after job duration from the mirror, would help maintainers decide.
- No CHANGELOG entry is needed, since nothing user-facing changes.
🤖 AI-generated review comment — agents make mistakes, so please verify before acting on it.
Hi @snazy, I'm a colleague of Donát from Develocity. Internally we are already using this and although as Donát said this is the first iteration, coupled with the MCP it can be pretty powerful already: the Docker build agent is able to capture cache usage and performance information and, speaking from experience, with a couple of questions an AI agent it was able to identify a couple of one-liners that ended up saving us a lot of CI agent time. It also already integrates with failure grouping, hopefully helping with troubleshooting. These are a couple of things that come to mind, I hope it helps. |
Branch builds of apache/polaris publish a Build Scan for the image the Docker image build job builds.
a7886d5 to
22ce45a
Compare
|
I've addressed the review items on this PR. |






Publishes a Develocity Build Scan for the image the
Polaris Docker Image Buildjob builds. The Gradle builds already publish Build Scans to develocity.apache.org. With this change the image build does too, showing the duration and cache use of each Dockerfile step, the build log and the packages in the image.A new
Start Develocity Docker build agentstep runs the Develocity Docker build agent beside the build, using thesetup-dockeraction fromgradle/develocity-actions. The agent captures what reaches BuildKit, so the Dockerfile and the Quarkus image build stay as they are.The scans go to develocity.apache.org under the
polarisproject, with theDEVELOCITY_ACCESS_KEYsecret the Gradle builds already use. The step runs only on branch builds of apache/polaris. These are the runs that publish the Gradle Build Scans to develocity.apache.org. Other runs skip the step and build the image as before.For each build the agent sends the BuildKit record: the Dockerfile steps with their timings, cache hits and logs, the git repository and commit, the image name, the hostname, user name and OS, and a link to the CI run. It also sends the list of packages in the image, which
develocity-package-scan-enabled: falseturns off. It sends no IP addresses.Tested on a mirror of this repository, where the job built the image and published its Build Scan.
Documentation for the action: https://github.com/gradle/develocity-actions#setup-docker-action
The pinned version of the action is on the ASF actions allowlist: apache/infrastructure-actions#1364
Checklist
CHANGELOG.md(if needed)site/content/in-dev/unreleased(if needed)