Skip to content

PHOENIX-7554: Do not run scalatests when -DskipTests parameter is pre…#152

Merged
richardantal merged 1 commit intoapache:masterfrom
richardantal:PHOENIX-7554
Mar 21, 2025
Merged

PHOENIX-7554: Do not run scalatests when -DskipTests parameter is pre…#152
richardantal merged 1 commit intoapache:masterfrom
richardantal:PHOENIX-7554

Conversation

@richardantal
Copy link
Copy Markdown
Contributor

…sent

@richardantal richardantal requested a review from stoty March 19, 2025 15:02
@stoty
Copy link
Copy Markdown
Contributor

stoty commented Mar 19, 2025

💔 -1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 5m 12s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
-1 ❌ test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ master Compile Tests _
+0 🆗 mvndep 2m 26s Maven dependency ordering for branch
-1 ❌ mvninstall 0m 8s root in master failed.
-1 ❌ compile 0m 6s root in master failed.
-1 ❌ javadoc 0m 9s phoenix5-spark in master failed.
-1 ❌ javadoc 0m 9s phoenix5-spark3 in master failed.
-1 ❌ javadoc 0m 6s root in master failed.
_ Patch Compile Tests _
+0 🆗 mvndep 0m 14s Maven dependency ordering for patch
-1 ❌ mvninstall 0m 6s root in the patch failed.
-1 ❌ compile 0m 6s root in the patch failed.
-1 ❌ javac 0m 6s root in the patch failed.
+1 💚 whitespace 0m 0s The patch has no whitespace issues.
+1 💚 xml 0m 4s The patch has no ill-formed XML file.
-1 ❌ javadoc 0m 8s phoenix5-spark in the patch failed.
-1 ❌ javadoc 0m 10s phoenix5-spark3 in the patch failed.
-1 ❌ javadoc 0m 6s root in the patch failed.
_ Other Tests _
-1 ❌ unit 0m 6s root in the patch failed.
-1 ❌ asflicense 0m 30s The patch generated 4 ASF License warnings.
10m 16s
Subsystem Report/Notes
Docker ClientAPI=1.48 ServerAPI=1.48 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-152/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR #152
JIRA Issue PHOENIX-7554
Optional Tests dupname asflicense javac javadoc unit xml compile
uname Linux fce030b9633c 5.15.0-134-generic #145-Ubuntu SMP Wed Feb 12 20:08:39 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev/phoenix-connectors-personality.sh
git revision master / 09afb21
Default Java Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08
mvninstall https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-152/1/artifact/yetus-general-check/output/branch-mvninstall-root.txt
compile https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-152/1/artifact/yetus-general-check/output/branch-compile-root.txt
javadoc https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-152/1/artifact/yetus-general-check/output/branch-javadoc-phoenix5-spark.txt
javadoc https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-152/1/artifact/yetus-general-check/output/branch-javadoc-phoenix5-spark3.txt
javadoc https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-152/1/artifact/yetus-general-check/output/branch-javadoc-root.txt
mvninstall https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-152/1/artifact/yetus-general-check/output/patch-mvninstall-root.txt
compile https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-152/1/artifact/yetus-general-check/output/patch-compile-root.txt
javac https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-152/1/artifact/yetus-general-check/output/patch-compile-root.txt
javadoc https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-152/1/artifact/yetus-general-check/output/patch-javadoc-phoenix5-spark.txt
javadoc https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-152/1/artifact/yetus-general-check/output/patch-javadoc-phoenix5-spark3.txt
javadoc https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-152/1/artifact/yetus-general-check/output/patch-javadoc-root.txt
unit https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-152/1/artifact/yetus-general-check/output/patch-unit-root.txt
Test Results https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-152/1/testReport/
asflicense https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-152/1/artifact/yetus-general-check/output/patch-asflicense-problems.txt
Max. process+thread count 52 (vs. ulimit of 30000)
modules C: phoenix5-spark phoenix5-spark3 . U: .
Console output https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-152/1/console
versions git=2.7.4 maven=3.3.9
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Copy link
Copy Markdown
Contributor

@stoty stoty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 LGTM

Good idea.

@richardantal richardantal merged commit 8247827 into apache:master Mar 21, 2025
1 check passed
@richardantal
Copy link
Copy Markdown
Contributor Author

Thank you for the review

stoty pushed a commit to stoty/phoenix-connectors that referenced this pull request Sep 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants