Skip to content

MINOR: [1.17.x] Upgrade Thrift to 0.25.0 - #3974

Open
adoroszlai wants to merge 2 commits into
apache:parquet-1.17.xfrom
adoroszlai:backport-thrift-0.25.0-1.17.x
Open

adoroszlai wants to merge 2 commits into
apache:parquet-1.17.xfrom
adoroszlai:backport-thrift-0.25.0-1.17.x

Conversation

@adoroszlai

Copy link
Copy Markdown

Rationale for this change

Backport Thrift version bump to 1.17.x for security.

What changes are included in this PR?

Are these changes tested?

https://github.com/adoroszlai/parquet-java/actions/runs/44486915466
https://github.com/adoroszlai/parquet-java/actions/runs/44486915416

Are there any user-facing changes?

From #3891:

Builds require Thrift compiler 0.25.0. The runtime includes stricter validation for malformed input; the required libthrift version for parquet-thrift is updated. No Parquet file-format or public Parquet API change is introduced.

Steve Loughran and others added 2 commits November 19, 2026 09:20
* apacheGH-3572

Bump thrift to 0.23

Added instructions in docs as to where to find the
gpg/sha signatures and a link to the thrift team KEYS file.

* Thrift 0.23 now checks limits (good!) on read write and depth

But it means: if you don't supply a TTransport to TProtocol ctor
you hit an NPE during IO whenever those limits are validated.

Add a StubTTransport which no-ops the read range check and
declares there's no limit on depth checking.

* Spotless

* review feedback

(cherry picked from commit fb5d512)
Backport the relevant parts of apache#3855 directly from 0.23.0 to 0.25.0.
Update the runtime and compiler together, align CI and build instructions,
and implement the transport reset method required by Thrift 0.25.0.

(cherry picked from commit b97860d)

Co-authored-by: Fokko Driesprong <fokko@apache.org>
Co-authored-by: Codex <codex@openai.com>
(cherry picked from commit 01bb09c)
@adoroszlai

Copy link
Copy Markdown
Author

TestByteBitPacking512VectorLE is still flaky, as explained in #3954 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants