Repository navigation
GH-3558: Properly close buffers #3559
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
24 commits
Select commit
Hold shift + click to select a range
a494af3
GH-3558: Properly close buffers
Fokko d1a7cec
Track the buffers and close all the resources in tests
Fokko 00931ba
Disable verification for now
Fokko e4dc4fc
Merge branch 'fd-correctly-close-buffers' of github.com:Fokko/parquet…
Fokko ca0ce18
Reduce changes
Fokko 0ec9fde
Merge branch 'master' into fd-correctly-close-buffers
Fokko a470682
Merge branch 'master' of github.com:apache/parquet-java into fd-corre…
Fokko c6e92d1
Merge branch 'fd-correctly-close-buffers' of github.com:Fokko/parquet…
Fokko ffd978e
Spotless
Fokko 81297e1
Revert some unrelated changes
Fokko 6a2fe5e
Thanks Gang
Fokko 4b45d07
Merge branch 'master' into fd-correctly-close-buffers
Fokko 8fc07d2
Merge branch 'master' of github.com:apache/parquet-java into fd-corre…
Fokko 4fbc84e
Revert "Thanks Gang"
Fokko e1edc2d
Release in try-catch
Fokko cb6d8f5
Fix failing test
Fokko 28778e6
Revert unrelated changes
Fokko 8bc2f2d
Merge branch 'master' into fd-correctly-close-buffers
Fokko 84dd78f
Move registering the buffer up
Fokko 15242c9
Revert unrelated change
Fokko f0703ef
Merge branch 'master' of github.com:apache/parquet-java into fd-corre…
Fokko 83d784d
Merge branch 'master' of github.com:apache/parquet-java into fd-corre…
Fokko a32e652
Merge branch 'master' of github.com:apache/parquet-java into fd-corre…
Fokko 85da48b
Merge branch 'master' of github.com:apache/parquet-java into fd-corre…
Fokko File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,33 @@ | ||
| <?xml version="1.0"?> | ||
| <?xml-stylesheet type="text/xsl" href="configuration.xsl"?> | ||
| <!-- | ||
| Licensed to the Apache Software Foundation (ASF) under one | ||
| or more contributor license agreements. See the NOTICE file | ||
| distributed with this work for additional information | ||
| regarding copyright ownership. The ASF licenses this file | ||
| to you under the Apache License, Version 2.0 (the | ||
| "License"); you may not use this file except in compliance | ||
| with the License. You may obtain a copy of the License at | ||
|
|
||
| http://www.apache.org/licenses/LICENSE-2.0 | ||
|
|
||
| Unless required by applicable law or agreed to in writing, software | ||
| distributed under the License is distributed on an "AS IS" BASIS, | ||
| WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| See the License for the specific language governing permissions and | ||
| limitations under the License. | ||
| --> | ||
| <configuration> | ||
| <property> | ||
| <name>fs.file.checksum.verify</name> | ||
| <value>false</value> | ||
| <description> | ||
| Disable checksum verification on the local file system used by tests. | ||
| Hadoop's ChecksumFileSystem.readVectored allocates checksum buffers via | ||
| the caller-supplied ByteBufferAllocator without releasing them; the | ||
| leaked buffers trip TrackingByteBufferAllocator leak detection in tests. | ||
| Turning off checksum verification skips the checksum read path entirely | ||
| and avoids the leak. | ||
| </description> | ||
| </property> | ||
| </configuration> | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is actually a Hadoop bug, which we should not fix in Parquet: https://issues.apache.org/jira/browse/HADOOP-19901