NIFI-16097 Added enable.idemotence Option in Publish Kafka Processor#11413
Open
loguylo wants to merge 1 commit into
Open
NIFI-16097 Added enable.idemotence Option in Publish Kafka Processor#11413loguylo wants to merge 1 commit into
loguylo wants to merge 1 commit into
Conversation
loguylo
force-pushed
the
NIFI-16097
branch
2 times, most recently
from
f5b9d83 to
da4743d
Compare
exceptionfactory
left a comment
exceptionfactory
left a comment
Contributor
There was a problem hiding this comment.
Thanks for proposing this additional configuration option @loguylo. This looks like a straightforward addition on initial review, I noted one stylistic recommendation.
Comment on lines
+146
to
+148
| .description("Specifies whether the producer will ensure that exactly one copy of each message is written in the stream. " + | ||
| "If set to ‘false’, producer retries due to broker failures, etc., may write duplicates of the retried message in the stream. " + | ||
| "Corresponds to Kafka Client enable.idempotence property.") |
Contributor
There was a problem hiding this comment.
A multiline string can be used instead of string concatenation for the description
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
NIFI-16097
Tracking
Please complete the following tracking steps prior to pull request creation.
Issue Tracking
Pull Request Tracking
NIFI-00000NIFI-00000VerifiedstatusPull Request Formatting
mainbranchVerification
Please indicate the verification steps performed prior to pull request creation.
Build
./mvnw clean install -P contrib-checkLicensing
LICENSEandNOTICEfilesDocumentation