Skip to content

NIFI-16092 - Fix flaky TestStandardRecordProcessorBlocker.TimeoutBlock.testBlockAndUnblock #11408

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
exceptionfactory merged 1 commit into from
Jul 8, 2026
+8 −2
Merged

NIFI-16092 - Fix flaky TestStandardRecordProcessorBlocker.TimeoutBlock.testBlockAndUnblock #11408

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions ...g/apache/nifi/processors/aws/kinesis/stream/pause/TestStandardRecordProcessorBlocker.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,7 @@ public void testBlockAndUnblock() {
blockerInspector.awaitBlockAwaited();
assertTrue(thread.isAlive());

blockerInspector.awaitThreadParked(thread);
recordProcessorBlocker.unblock();
blockerInspector.awaitBlockExited();
}
Expand Down Expand Up @@ -96,6 +97,7 @@ public void testBlockAndUnblock() {
blockerInspector.awaitBlockAwaited();
assertTrue(thread.isAlive());

blockerInspector.awaitThreadParked(thread);
recordProcessorBlocker.unblock();
blockerInspector.awaitBlockExited();
}
Expand Down Expand Up @@ -163,8 +165,8 @@ private static Runnable createRunnableWithInspector(final StandardRecordProcesso

private static class TestThreadInspector {
private static final Duration BUSY_WAIT_MAX_DURATION = Duration.ofSeconds(5);
private boolean blockAwaited = false;
private boolean blockExited = false;
private volatile boolean blockAwaited = false;
private volatile boolean blockExited = false;

public void onBlockAwaited() {
blockAwaited = true;
Expand All @@ -182,6 +184,10 @@ public void awaitBlockExited() {
busyWait(() -> !blockExited);
}

public void awaitThreadParked(final Thread thread) {
busyWait(() -> thread.getState() != Thread.State.WAITING);
}

private void busyWait(final Supplier<Boolean> condition) {
final long maxWait = System.currentTimeMillis() + BUSY_WAIT_MAX_DURATION.toMillis();
do {
Expand Down
Loading