Skip to content

NIFI-16085 - Flow synchronization fails when a Parameter Provider-backed Parameter Context contains a parameter not flagged as provided#11403

Merged
kevdoran merged 2 commits into
apache:mainfrom
pvillard31:NIFI-16085
Jul 8, 2026

Conversation

@pvillard31

Copy link
Copy Markdown
Contributor

Summary

NIFI-16085 - Flow synchronization fails when a Parameter Provider-backed Parameter Context contains a parameter not flagged as provided

Tracking

Please complete the following tracking steps prior to pull request creation.

Issue Tracking

Pull Request Tracking

  • Pull Request title starts with Apache NiFi Jira issue number, such as NIFI-00000
  • Pull Request commit message starts with Apache NiFi Jira issue number, as such NIFI-00000
  • Pull request contains commits signed with a registered key indicating Verified status

Pull Request Formatting

  • Pull Request based on current revision of the main branch
  • Pull Request refers to a feature branch with one commit containing changes

Verification

Please indicate the verification steps performed prior to pull request creation.

Build

  • Build completed using ./mvnw clean install -P contrib-check
    • JDK 21
    • JDK 25

Licensing

  • New dependencies are compatible with the Apache License 2.0 according to the License Policy
  • New dependencies are documented in applicable LICENSE and NOTICE files

Documentation

  • Documentation formatting appears as expected in rendered files

…ked Parameter Context contains a parameter not flagged as provided
@pvillard31 pvillard31 added the bug label Jul 7, 2026
@kevdoran

kevdoran commented Jul 7, 2026

Copy link
Copy Markdown
Contributor

reviewing...

@kevdoran kevdoran left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for tracking this down. The fix looks correct and well-targeted — treating the context-level Parameter Provider binding as authoritative over the per-VersionedParameter provided flag is the right call, and threading providerBacked through the createParameter/createParameterMap paths covers the reconcile entry points I checked (with createParameterContextWithoutReferences intentionally keeping the serialized flag). The forced-provided path also degrades gracefully when the provider doesn't currently supply a name — createParameterMap logs and falls back to a null value rather than failing.

A couple of non-blocking suggestions on test coverage below; neither affects the correctness of the change.

Address review feedback: strengthen the unit test and system IT to assert the
reconciled parameter value is re-sourced from the Parameter Provider (rather
than only asserting no-throw / provided=true), covering the provider
value-sourcing branch end to end.
@kevdoran kevdoran merged commit 6e7b31f into apache:main Jul 8, 2026
13 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants