NIFI-16085 - Flow synchronization fails when a Parameter Provider-backed Parameter Context contains a parameter not flagged as provided#11403
Conversation
…ked Parameter Context contains a parameter not flagged as provided
|
reviewing... |
kevdoran
left a comment
There was a problem hiding this comment.
Thanks for tracking this down. The fix looks correct and well-targeted — treating the context-level Parameter Provider binding as authoritative over the per-VersionedParameter provided flag is the right call, and threading providerBacked through the createParameter/createParameterMap paths covers the reconcile entry points I checked (with createParameterContextWithoutReferences intentionally keeping the serialized flag). The forced-provided path also degrades gracefully when the provider doesn't currently supply a name — createParameterMap logs and falls back to a null value rather than failing.
A couple of non-blocking suggestions on test coverage below; neither affects the correctness of the change.
Address review feedback: strengthen the unit test and system IT to assert the reconciled parameter value is re-sourced from the Parameter Provider (rather than only asserting no-throw / provided=true), covering the provider value-sourcing branch end to end.
Summary
NIFI-16085 - Flow synchronization fails when a Parameter Provider-backed Parameter Context contains a parameter not flagged as provided
Tracking
Please complete the following tracking steps prior to pull request creation.
Issue Tracking
Pull Request Tracking
NIFI-00000NIFI-00000VerifiedstatusPull Request Formatting
mainbranchVerification
Please indicate the verification steps performed prior to pull request creation.
Build
./mvnw clean install -P contrib-checkLicensing
LICENSEandNOTICEfilesDocumentation