NIFI-16059: validate connector postMessage origin against the host or…#11379
Open
mcgilman wants to merge 1 commit into
Open
NIFI-16059: validate connector postMessage origin against the host or…#11379mcgilman wants to merge 1 commit into
mcgilman wants to merge 1 commit into
Conversation
…igin instead of the entity-controlled configurationUrl (CWE-346)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…igin instead of the entity-controlled configurationUrl (CWE-346)
Summary
NIFI-16059
Connector custom UIs are embedded in the application via an
<iframe>andcommunicate with the host through
window.postMessage. The host'sConnectorMessageHostderived the origin it trusted — for both inbound messagevalidation and the outbound
targetOrigin— from the connector-providedconfigurationUrl/detailsUrl. Because those URLs are controlled by theconnector entity, the entity could effectively attest to its own message
origin, which is an origin-validation weakness (CWE-346).
This change decouples the iframe
srcfrom the trusted origin. The host nowtrusts only the application's own origin (
document.location.origin), which isvalid because connector custom UIs are served by the same web server that serves
the application (the
configurationUrl/detailsUrlare built from theincoming request and contribute only the path, so the iframe is same-origin with
the parent).
Changes
ConnectorMessageHostexpectedOriginoption and the staticextractOrigin()helper.trustedOrigin(document.location.origin, via theDOCUMENTtoken), used for both inbound origin validation and the outbound
targetOrigin. Messages whoseevent.origindoes not match are dropped(fail-closed). The existing
event.source(iframecontentWindow) andmessage namespace/type checks are unchanged.
connector-configure/connector-detailexpectedOrigintostartListening(...).trustedOriginrather thanan origin derived from the entity URL.
Verification
attacker-controlled
configurationUrlis dropped, and that a message from theapplication origin is accepted.
it is posted with
targetOrigin === window.location.originand the expectedmessage namespace/type.
nx test nifi(full suite) andnx lint nifipass.Tracking
Please complete the following tracking steps prior to pull request creation.
Issue Tracking
Pull Request Tracking
NIFI-00000NIFI-00000Pull Request Formatting
mainbranchVerification
Please indicate the verification steps performed prior to pull request creation.
Build
mvn clean install -P contrib-checkLicensing
LICENSEandNOTICEfilesDocumentation