Conversation
There was a problem hiding this comment.
Thanks, interesting idea. Sorry for the delay. I've not got a lot of time for NetBeans things at the moment, but had a glance through. Few concerns, but nothing major.
We were discussing getting a first non-beta release out, which involves removing a few deprecated options first. Not sure if this should merge before or after that release.
I was wondering whether we could reduce duplication of some of these options by having some shared Linux options. That might require some thought given the current structure, and might not be worth the trouble. Depends if we might expect more Linux package types in future.
src/main/java/org/apache/netbeans/nbpackage/shell/TarScriptPackager.java
Outdated
Show resolved
Hide resolved
src/main/resources/org/apache/netbeans/nbpackage/shell/Messages.properties
Outdated
Show resolved
Hide resolved
src/main/resources/org/apache/netbeans/nbpackage/shell/shell.script.template
Outdated
Show resolved
Hide resolved
src/main/resources/org/apache/netbeans/nbpackage/shell/shell.desktop.template
Outdated
Show resolved
Hide resolved
d8b6cfc to
725b710
Compare
|
@neilcsmith-net Happy New Year! Any more thoughts on this PR? Does it need more changes? It it worthwhile to be merged? |
|
@oyarzun Happy New Year to you too! Apologies for delays in getting this in. I've been mostly out of the NetBeans loop for the last few months, and was hoping someone else might take a look at this as well in that time. I think this would be nice to get in, but I'm not sure whether we should concentrate on releasing the existing master in non-beta form before merging new packagers? @mbien @ebarboni any thoughts? I'll take another look to refresh myself on this as soon as I can, but I think all changes are OK as is. One thing I'd wondered about was abstracting some of the duplicate Linux options somehow, but that can probably be looked at after merging if at all. |
|
Hi, I think it could be merged beta7 or 1.0.0 is a decision that can be done for release later. |
|
Thanks @ebarboni but I don't agree with you that the version can be decided later. If we want the next release to be 1.0.0 then we need to do that before this is merged. |
for me this is only if we don't want this PR for 1.0.0 but we can go for a vote thread to have current nbpackage released as 1.0.0 |
Yes, I don't think we should merge this for 1.0.0 unless we plan on having more beta releases first (and personally I don't think we should do that). We had originally talked about stabilising the existing features and releasing 1.0.0. That needs a tidy up PR first to remove a few deprecated things. I will look at that next week, and aim to get a release vote started after that. Then we can merge this for the next release. @oyarzun sorry for the delay and tangential discussion there. |
|
@neilcsmith-net no problem. I agree with your thinking release 1.0.0 first. |
725b710 to
aee98b9
Compare
aee98b9 to
146605c
Compare
|
@neilcsmith-net Let me know if there are any other changes needed. |
146605c to
457da77
Compare
Adds an embedded tar script packager.
~/.local/appdir/usr/local/appdir