host/sm: Reject Legacy pairing confirm reflection attack#2201
Open
guy-m wants to merge 1 commit intoapache:masterfrom
Open
host/sm: Reject Legacy pairing confirm reflection attack#2201guy-m wants to merge 1 commit intoapache:masterfrom
guy-m wants to merge 1 commit intoapache:masterfrom
Conversation
guy-m
changed the title
guy-m
changed the title
guy-m
force-pushed
the
guym/jw_pair_reflection_attack
branch
from
5ff549b to
670d7b5
Compare
When the responder mirrors the initiator's confirm and random values (Sconfirm=Mconfirm, Srand=Mrand), the c1 check passes trivially, bypassing mismatch detection and causing an HCI encryption failure (0x06) instead of Pairing Failed (0x04). Detect Srand==Mrand in ble_sm_lgcy_random_rx and abort with LE_SM_ERR_CONFIRM_MISMATCH. Fixes SM/CEN/JW/BI-06-C and SM/CEN/PKE/BI-03-C
guy-m
force-pushed
the
guym/jw_pair_reflection_attack
branch
from
670d7b5 to
a2bb049
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the responder mirrors the initiator's confirm and random values
(Sconfirm=Mconfirm, Srand=Mrand), the c1 check passes trivially,
bypassing mismatch detection and causing an
HCI encryption failure (0x06) instead of Pairing Failed (0x04).
Detect Srand==Mrand in ble_sm_lgcy_random_rx and abort
with BLE_SM_ERR_CONFIRM_MISMATCH.
Fixes SM/CEN/JW/BI-06-C and SM/CEN/PKE/BI-03-C