Open
Conversation
mkasenberg
force-pushed
the
add-ble-hci-ipc
branch
from
b5fda2a to
76f90e2
Compare
mkasenberg
force-pushed
the
add-ble-hci-ipc
branch
2 times, most recently
from
daaf3d3 to
a9eb7aa
Compare
mkasenberg
changed the title
mkasenberg
force-pushed
the
add-ble-hci-ipc
branch
from
a9eb7aa to
772a87b
Compare
mkasenberg
force-pushed
the
add-ble-hci-ipc
branch
from
772a87b to
0979452
Compare
Contributor
Author
Contributor
|
LGTM |
Support for nRF5340.
mkasenberg
force-pushed
the
add-ble-hci-ipc
branch
from
0979452 to
3fa5c0e
Compare
Contributor
Author
|
Just rebased |
andrzej-kaczmarek
requested changes
Aug 14, 2025
| Enables LLCP tracing using HCI vendor-specific events. | ||
| value: '0' | ||
|
|
||
| BLE_LL_HCI_NOOP_AFTER_INIT: |
Contributor
There was a problem hiding this comment.
this should be a separate commit
| #define HCI_IPC_TYPE_EVT 0x04 | ||
| #define HCI_IPC_TYPE_ISO 0x05 | ||
| /* These two are not used actually */ | ||
| #define HCI_IPC_TYPE_EVT_DISCARDABLE 0x06 |
Contributor
There was a problem hiding this comment.
so looks like icbmsg uses simple H4, in such case it should simply use hci_h4
| - native | ||
| - dialog_cmac | ||
| - nrf5340 | ||
| - ipc |
Contributor
There was a problem hiding this comment.
icbmsg or ipc_icbmsg - I think the latter is more preferable as we may later opt rename nrf5340 and cmac to include ipc_ prefix as well -> @sjanc ?
| syscfg.defs: | ||
| BLE_TRANSPORT_IPC_BACKEND: | ||
| description: > | ||
| Select IPC backend. |
Contributor
There was a problem hiding this comment.
skip the intermediate ipc transport package, icbmsg should be directly included from nimble/transport
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related PR apache/mynewt-core#3312
Can be tested with a nRF5340 board:
Build cheat-sheet:
Erase all and disable APPROTECT:
nordic_pca10095_boot.zip
nordic_pca10095_app-advertiser.zip
nordic_pca10095_net_boot.zip
nordic_pca10095_net-blehci.zip