Console modes: --console=plain/rich/verbose/machine - #12697
Open
gnodet wants to merge 1 commit into
Open
Conversation
This was referenced Aug 7, 2026
gnodet
force-pushed
the
feature/build-report
branch
from
August 8, 2026 01:23
602fffb to
056dcf0
Compare
gnodet
force-pushed
the
feature/console-modes
branch
from
August 8, 2026 01:23
b0617f7 to
1a419b7
Compare
gnodet
added a commit
that referenced
this pull request
Aug 8, 2026
Add --warning-mode CLI flag (summary/all/none/fail) for controlling how build warnings are displayed. Enrich BuilderProblem with key, suggestion, documentationUrl, INFO severity, and a builder API. Add DiagnosticReporter service and DefaultDiagnosticCollector for deduplication across parallel module builds. Part 4 of the #12572 split (depends on console modes PR #12697). Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
gnodet
force-pushed
the
feature/console-modes
branch
from
August 8, 2026 05:35
1a419b7 to
1e4c616
Compare
gnodet
force-pushed
the
feature/build-report
branch
2 times, most recently
from
August 8, 2026 12:14
a1ee585 to
0f31ce2
Compare
gnodet
force-pushed
the
feature/console-modes
branch
from
August 8, 2026 12:14
1e4c616 to
eb4b145
Compare
gnodet
added a commit
that referenced
this pull request
Aug 8, 2026
Add --warning-mode CLI flag (summary/all/none/fail) for controlling how build warnings are displayed. Enrich BuilderProblem with key, suggestion, documentationUrl, INFO severity, and a builder API. Add DiagnosticReporter service and DefaultDiagnosticCollector for deduplication across parallel module builds. Part 4 of the #12572 split (depends on console modes PR #12697). Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
gnodet
force-pushed
the
feature/console-modes
branch
from
August 8, 2026 19:17
eb4b145 to
35cf036
Compare
gnodet
added a commit
that referenced
this pull request
Aug 8, 2026
Add --warning-mode CLI flag (summary/all/none/fail) for controlling how build warnings are displayed. Enrich BuilderProblem with key, suggestion, documentationUrl, INFO severity, and a builder API. Add DiagnosticReporter service and DefaultDiagnosticCollector for deduplication across parallel module builds. Part 4 of the #12572 split (depends on console modes PR #12697). Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
gnodet
force-pushed
the
feature/build-report
branch
from
August 8, 2026 19:35
8083c89 to
170bd72
Compare
gnodet
force-pushed
the
feature/console-modes
branch
from
August 8, 2026 19:35
35cf036 to
e06f638
Compare
gnodet
added a commit
that referenced
this pull request
Aug 8, 2026
Add --warning-mode CLI flag (summary/all/none/fail) for controlling how build warnings are displayed. Enrich BuilderProblem with key, suggestion, documentationUrl, INFO severity, and a builder API. Add DiagnosticReporter service and DefaultDiagnosticCollector for deduplication across parallel module builds. Part 4 of the #12572 split (depends on console modes PR #12697). Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
gnodet
force-pushed
the
feature/build-report
branch
from
August 8, 2026 21:48
170bd72 to
af0cc72
Compare
gnodet
force-pushed
the
feature/console-modes
branch
from
August 8, 2026 21:48
e06f638 to
77ddf3a
Compare
gnodet
added a commit
that referenced
this pull request
Aug 8, 2026
Add --warning-mode CLI flag (summary/all/none/fail) for controlling how build warnings are displayed. Enrich BuilderProblem with key, suggestion, documentationUrl, INFO severity, and a builder API. Add DiagnosticReporter service and DefaultDiagnosticCollector for deduplication across parallel module builds. Part 4 of the #12572 split (depends on console modes PR #12697). Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
4 tasks
- plain: compact one-line-per-module output, auto-selected in CI - rich: JLine status bar with live reactor progress, auto-selected on TTY - verbose: full mojo-level output, current Maven 4.0 default - machine: JSON lines, one typed JSON object per lifecycle event - Auto-detection: CI → plain, interactive TTY → rich, otherwise → verbose
gnodet
force-pushed
the
feature/console-modes
branch
from
August 9, 2026 08:11
77ddf3a to
6b6fc7f
Compare
gnodet
force-pushed
the
feature/build-report
branch
from
August 9, 2026 08:11
af0cc72 to
3658983
Compare
gnodet
marked this pull request as ready for review
August 9, 2026 08:11
gnodet
commented
Aug 9, 2026
gnodet
left a comment
gnodet
left a comment
Contributor
Author
There was a problem hiding this comment.
Well-structured PR adding four console modes with comprehensive test coverage (1317 lines of tests). Two issues found, one concurrency bug.
Also noted:
- The
Options.console()API addition follows the established pattern (Optional<String>, same ascolor()). The@Experimentalannotation means downstream breakage is acceptable. - JSON escaping in
MachineBuildEventListenercorrectly handles all RFC 8259 required escapes, with test coverage for edge cases. - Test coverage is strong: 5 new test classes covering all four console modes.
This review was generated by an AI agent and may contain inaccuracies. Please verify all suggestions before applying.
Claude Code on behalf of gnodet
| @Override | ||
| public void projectFinished(String projectId) { | ||
| activeProjects.remove(projectId); | ||
| completedProjects++; |
Contributor
Author
There was a problem hiding this comment.
Race condition: completedProjects++ is not atomic. The field is volatile int (line 103) but ++ is a non-atomic read-increment-write compound operation. In parallel builds (-T N), concurrent calls to projectFinished() from worker threads can lose increments, causing the progress counter to under-report.
The same class already uses AtomicInteger for warningCount and errorCount (lines 133-136).
Suggested change
| completedProjects++; | |
| completedProjects.incrementAndGet(); |
(with completedProjects changed to AtomicInteger at line 103)
| * </li> | ||
| * </ol> | ||
| */ | ||
| String determineConsoleMode(MavenContext context) { |
Contributor
Author
There was a problem hiding this comment.
Unrecognized --console values (including typos like --console=plian) silently fall through to auto-detection. This is inconsistent with the existing --color option in LookupInvoker.java (lines 274-276) which throws IllegalArgumentException for invalid values. Adding validation for consistency would help users catch configuration mistakes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Part 3 of the logging feature chain. Depends on #12695 (build report).
Adds the
--consoleCLI flag with four output modes:plain— compact one-line-per-module output, ideal for CI (auto-selected in CI environments)rich— JLine status bar with live reactor progress (auto-selected on interactive TTYs)verbose— full mojo-level output, current Maven 4.0 default behaviormachine— JSON lines: one typed JSON object per lifecycle event, designed for piping to external toolsAuto-detection (
--console=auto, the default): CI → plain, interactive TTY → rich, otherwise → verbose.Files changed (16 files, ~4000 insertions)
Options.java(+console())PlainExecutionEventLogger,RichBuildEventListener,RichExecutionEventLogger,MachineBuildEventListener,MachineExecutionEventLoggerCommonsCliOptions,LayeredOptions,LookupInvoker(preliminary interactive detection),MavenInvoker(console mode switch + transfer listener)ExecutionEventLogger(version info on failure)PR chain
mvnlogviewerTest plan
mvn test -pl impl/maven-cli— all 692 tests passmvn test -pl impl/maven-core— all tests pass🤖 Generated with Claude Code