Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR updates javadoc comments to follow Oracle javadoc guidelines, focusing on proper formatting and punctuation standards across multiple Java source files in the Maven Shade Plugin.
- Standardizes javadoc comment formatting with proper punctuation
- Converts single-line author comments to multi-line format
- Updates parameter descriptions to use lowercase and proper periods
Reviewed Changes
Copilot reviewed 18 out of 18 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| ResourceTransformer.java | Updates author comment formatting and method parameter descriptions |
| ResourceBundleAppendingTransformer.java | Adds periods to class and method descriptions |
| ReproducibleResourceTransformer.java | Standardizes parameter descriptions and exception documentation |
| ManifestResourceTransformer.java | Removes period from parameter description |
| GroovyResourceTransformer.java | Adds period to class description |
| ApacheLicenseResourceTransformer.java | Adds period to class description |
| SimpleRelocator.java | Adds periods to field descriptions |
| Relocator.java | Updates author comment formatting |
| MavenJDOMWriter.java | Extensive standardization of method and field descriptions |
| Counter.java | Updates field and method descriptions with proper formatting |
| ShadeMojo.java | Standardizes parameter and method descriptions |
| RelativizePath.java | Removes empty javadoc block and improves method description |
| SimpleFilter.java | Updates parameter descriptions and deprecation formatting |
| MinijarFilter.java | Standardizes exception documentation |
| Filter.java | Updates parameter and return descriptions |
| Shader.java | Updates exception documentation |
| ShadeRequest.java | Standardizes parameter descriptions throughout |
| DefaultShader.java | Updates interface and class descriptions |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
slachiewicz
approved these changes
Sep 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.