Skip to content

Migrate the AbstractIT-based integration test classes to JUnit 5 #294

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
slachiewicz merged 1 commit into from
Aug 9, 2026
Merged

Migrate the AbstractIT-based integration test classes to JUnit 5 #294

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 19 additions & 1 deletion pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -205,6 +205,7 @@ under the License.
<scope>test</scope>
</dependency>
<dependency>
<!-- still required by AbstractMojoTestCase (deprecated, PlexusTestCase/JUnit 3 based); see RemoteResourcesMojoTest -->
<groupId>junit</groupId>
<artifactId>junit</artifactId>
<version>4.13.2</version>
Expand All @@ -216,6 +217,17 @@ under the License.
</exclusion>
</exclusions>
</dependency>
<dependency>
<groupId>org.junit.jupiter</groupId>
<artifactId>junit-jupiter-api</artifactId>
<scope>test</scope>
</dependency>
<dependency>
<!-- runs RemoteResourcesMojoTest (AbstractMojoTestCase/PlexusTestCase, JUnit 3 style) on the JUnit Platform -->
<groupId>org.junit.vintage</groupId>
<artifactId>junit-vintage-engine</artifactId>
<scope>test</scope>
</dependency>
<dependency>
<groupId>org.apache.maven.plugin-testing</groupId>
<artifactId>maven-plugin-testing-harness</artifactId>
Expand Down Expand Up @@ -362,7 +374,13 @@ under the License.
</goals>
<configuration>
<failOnWarning>true</failOnWarning>
<ignoredDependencies>org.slf4j:slf4j-simple:*</ignoredDependencies>
<ignoredDependencies>
<ignoredDependency>org.slf4j:slf4j-simple:*</ignoredDependency>
<!-- still needed at test runtime by the deprecated AbstractMojoTestCase/PlexusTestCase (JUnit 3) -->
<ignoredDependency>junit:junit:*</ignoredDependency>
<!-- JUnit Platform test engines, discovered via ServiceLoader, never referenced from bytecode -->
<ignoredDependency>org.junit.vintage:junit-vintage-engine:*</ignoredDependency>
</ignoredDependencies>
</configuration>
</execution>
</executions>
Expand Down
4 changes: 2 additions & 2 deletions src/test/java/org/apache/maven/plugin/resources/remote/it/AbstractIT.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,10 +19,10 @@
package org.apache.maven.plugin.resources.remote.it;

import org.apache.maven.plugin.resources.remote.it.support.BootstrapInstaller;
import org.junit.Before;
import org.junit.jupiter.api.BeforeEach;

public abstract class AbstractIT {
@Before
@BeforeEach
public void setUp() throws Exception {
BootstrapInstaller.install();
}
Expand Down
4 changes: 2 additions & 2 deletions src/test/java/org/apache/maven/plugin/resources/remote/it/ITBadDependencyPoms.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,9 +26,9 @@
import org.apache.maven.shared.verifier.VerificationException;
import org.apache.maven.shared.verifier.Verifier;
import org.codehaus.plexus.util.FileUtils;
import org.junit.Test;
import org.junit.jupiter.api.Test;

import static org.junit.Assert.assertTrue;
import static org.junit.jupiter.api.Assertions.assertTrue;

/**
* @author Benjamin Bentmann
Expand Down
4 changes: 2 additions & 2 deletions src/test/java/org/apache/maven/plugin/resources/remote/it/ITCustomFilterDelimiter.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,9 +26,9 @@
import org.apache.maven.shared.verifier.VerificationException;
import org.apache.maven.shared.verifier.Verifier;
import org.codehaus.plexus.util.FileUtils;
import org.junit.Test;
import org.junit.jupiter.api.Test;

import static org.junit.Assert.assertTrue;
import static org.junit.jupiter.api.Assertions.assertTrue;

public class ITCustomFilterDelimiter extends AbstractIT {
@Test
Expand Down
4 changes: 2 additions & 2 deletions src/test/java/org/apache/maven/plugin/resources/remote/it/ITFilterLocalOverride.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,9 +26,9 @@
import org.apache.maven.shared.verifier.VerificationException;
import org.apache.maven.shared.verifier.Verifier;
import org.codehaus.plexus.util.FileUtils;
import org.junit.Test;
import org.junit.jupiter.api.Test;

import static org.junit.Assert.assertTrue;
import static org.junit.jupiter.api.Assertions.assertTrue;

public class ITFilterLocalOverride extends AbstractIT {
@Test
Expand Down
4 changes: 2 additions & 2 deletions src/test/java/org/apache/maven/plugin/resources/remote/it/ITGenerateFromBundle.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,9 +26,9 @@
import org.apache.maven.shared.verifier.VerificationException;
import org.apache.maven.shared.verifier.Verifier;
import org.codehaus.plexus.util.FileUtils;
import org.junit.Test;
import org.junit.jupiter.api.Test;

import static org.junit.Assert.assertTrue;
import static org.junit.jupiter.api.Assertions.assertTrue;

public class ITGenerateFromBundle extends AbstractIT {
@Test
Expand Down
4 changes: 2 additions & 2 deletions ...rg/apache/maven/plugin/resources/remote/it/ITGenerateFromBundleWithTypeAndClassifier.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,9 +26,9 @@
import org.apache.maven.shared.verifier.VerificationException;
import org.apache.maven.shared.verifier.Verifier;
import org.codehaus.plexus.util.FileUtils;
import org.junit.Test;
import org.junit.jupiter.api.Test;

import static org.junit.Assert.assertTrue;
import static org.junit.jupiter.api.Assertions.assertTrue;

public class ITGenerateFromBundleWithTypeAndClassifier extends AbstractIT {
@Test
Expand Down
4 changes: 2 additions & 2 deletions src/test/java/org/apache/maven/plugin/resources/remote/it/ITGenerateFromOverride.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,9 +26,9 @@
import org.apache.maven.shared.verifier.VerificationException;
import org.apache.maven.shared.verifier.Verifier;
import org.codehaus.plexus.util.FileUtils;
import org.junit.Test;
import org.junit.jupiter.api.Test;

import static org.junit.Assert.assertTrue;
import static org.junit.jupiter.api.Assertions.assertTrue;

public class ITGenerateFromOverride extends AbstractIT {
@Test
Expand Down
4 changes: 2 additions & 2 deletions src/test/java/org/apache/maven/plugin/resources/remote/it/ITGetDependencyProjects.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,9 +26,9 @@
import org.apache.maven.shared.verifier.VerificationException;
import org.apache.maven.shared.verifier.Verifier;
import org.codehaus.plexus.util.FileUtils;
import org.junit.Test;
import org.junit.jupiter.api.Test;

import static org.junit.Assert.assertTrue;
import static org.junit.jupiter.api.Assertions.assertTrue;

/**
* @author Benjamin Bentmann
Expand Down
8 changes: 4 additions & 4 deletions src/test/java/org/apache/maven/plugin/resources/remote/it/ITRunOnlyAtExecutionRoot.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,11 +27,11 @@
import org.apache.maven.shared.verifier.Verifier;
import org.codehaus.plexus.util.FileUtils;
import org.codehaus.plexus.util.Os;
import org.junit.Test;
import org.junit.jupiter.api.Test;

import static org.junit.Assert.assertFalse;
import static org.junit.Assert.assertTrue;
import static org.junit.Assume.assumeTrue;
import static org.junit.jupiter.api.Assertions.assertFalse;
import static org.junit.jupiter.api.Assertions.assertTrue;
import static org.junit.jupiter.api.Assumptions.assumeTrue;

/**
* @author Benjamin Bentmann
Expand Down
4 changes: 2 additions & 2 deletions src/test/java/org/apache/maven/plugin/resources/remote/it/ITSupplementalArtifact.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,9 +26,9 @@
import org.apache.maven.shared.verifier.VerificationException;
import org.apache.maven.shared.verifier.Verifier;
import org.codehaus.plexus.util.FileUtils;
import org.junit.Test;
import org.junit.jupiter.api.Test;

import static org.junit.Assert.assertTrue;
import static org.junit.jupiter.api.Assertions.assertTrue;

/**
* @author John Casey
Expand Down
Loading