Skip to content

Migrate legacy plugin Javadoc annotations - #291

Merged
slachiewicz merged 1 commit into
apache:masterfrom
wilx:agent/legacy-plugin-annotations
Aug 9, 2026
Merged

Migrate legacy plugin Javadoc annotations#291
slachiewicz merged 1 commit into
apache:masterfrom
wilx:agent/legacy-plugin-annotations

Conversation

@wilx

@wilx wilx commented Aug 8, 2026

Copy link
Copy Markdown
Contributor

This updates the plugin sources in the maven-remote-resources-test and
MRRESOURCES-121-dependencies-ignored integration-test projects to use
maven-plugin-annotations instead of the legacy Maven Plugin Tools Javadoc
tags.

The conversion preserves each mojo's name, default lifecycle phase, and
parameter metadata. Both fixtures now declare maven-plugin-annotations with
provided scope and use the filtered @version.maven-plugin-tools@ value so
they stay aligned with the Plugin Tools version used by the reactor.

This is part of removing reliance on the legacy QDox-backed Javadoc-tag
extractor discussed in apache/maven-plugin-tools#718.
There is no runtime behavior change to the Remote Resources Plugin.

Validation on JDK 21:

  • Maven 3.9.16: mvn -B -V clean verify -Prun-its
    • Invoker: 7 passed, 0 failed, 0 errors, 0 skipped
    • Failsafe: 9 tests passed, 0 failures, 0 errors, 0 skipped
  • Maven 4.0.0-rc-6: mvn -B -V clean verify -Prun-its
    • Invoker: 7 passed, 0 failed, 0 errors, 0 skipped
    • Failsafe: 9 tests passed, 0 failures, 0 errors, 0 skipped

Following this checklist to help us incorporate your
contribution quickly and easily:

  • Your pull request should address just one issue, without pulling in other changes.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Each commit in the pull request should have a meaningful subject line and body.
    Note that commits might be squashed by a maintainer on merge.
  • Write unit tests that match behavioral changes, where the tests fail if the changes to the runtime are not applied.
    This may not always be possible but is a best-practice. This change updates existing integration-test fixtures and does not change runtime behavior.
  • Run mvn verify to make sure basic checks pass.
    A more thorough check will be performed on your pull request automatically.
  • You have run the integration tests successfully (mvn -Prun-its verify).

If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.

To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.

Replace legacy Maven Plugin Tools Javadoc tags in the remote-resources integration-test mojos with maven-plugin-annotations metadata. Add provided annotation dependencies using the filtered Plugin Tools version.
@wilx
wilx marked this pull request as ready for review August 8, 2026 13:47
@slachiewicz
slachiewicz merged commit 6dfa174 into apache:master Aug 9, 2026
17 checks passed
@github-actions github-actions Bot added this to the 3.3.0 milestone Aug 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants