Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -651,7 +651,7 @@
}
} else {
getLog().debug("Use project resource '" + source + "' as resource");
FilteringUtils.copyFile(source, outputFile, null, null);

Check warning on line 654 in src/main/java/org/apache/maven/plugin/resources/remote/AbstractProcessRemoteResourcesMojo.java

View workflow job for this annotation

GitHub Actions / Verify / ubuntu-latest jdk-17-zulu 3.10.0-rc-1

copyFile(java.io.File,java.io.File,java.lang.String,org.apache.maven.shared.filtering.FilterWrapper[]) in org.apache.maven.shared.filtering.FilteringUtils has been deprecated

Check warning on line 654 in src/main/java/org/apache/maven/plugin/resources/remote/AbstractProcessRemoteResourcesMojo.java

View workflow job for this annotation

GitHub Actions / Verify / macos-latest jdk-21-zulu 3.10.0-rc-1

copyFile(java.io.File,java.io.File,java.lang.String,org.apache.maven.shared.filtering.FilterWrapper[]) in org.apache.maven.shared.filtering.FilteringUtils has been deprecated

Check warning on line 654 in src/main/java/org/apache/maven/plugin/resources/remote/AbstractProcessRemoteResourcesMojo.java

View workflow job for this annotation

GitHub Actions / Verify / macos-latest jdk-8-zulu 3.10.0-rc-1

copyFile(java.io.File,java.io.File,java.lang.String,org.apache.maven.shared.filtering.FilterWrapper[]) in org.apache.maven.shared.filtering.FilteringUtils has been deprecated

Check warning on line 654 in src/main/java/org/apache/maven/plugin/resources/remote/AbstractProcessRemoteResourcesMojo.java

View workflow job for this annotation

GitHub Actions / Verify / ubuntu-latest jdk-25-zulu 3.10.0-rc-1

copyFile(java.io.File,java.io.File,java.lang.String,org.apache.maven.shared.filtering.FilterWrapper[]) in org.apache.maven.shared.filtering.FilteringUtils has been deprecated

Check warning on line 654 in src/main/java/org/apache/maven/plugin/resources/remote/AbstractProcessRemoteResourcesMojo.java

View workflow job for this annotation

GitHub Actions / Verify / macos-latest jdk-25-zulu 3.10.0-rc-1

copyFile(java.io.File,java.io.File,java.lang.String,org.apache.maven.shared.filtering.FilterWrapper[]) in org.apache.maven.shared.filtering.FilteringUtils has been deprecated

Check warning on line 654 in src/main/java/org/apache/maven/plugin/resources/remote/AbstractProcessRemoteResourcesMojo.java

View workflow job for this annotation

GitHub Actions / Verify / ubuntu-latest jdk-8-zulu 3.10.0-rc-1

copyFile(java.io.File,java.io.File,java.lang.String,org.apache.maven.shared.filtering.FilterWrapper[]) in org.apache.maven.shared.filtering.FilteringUtils has been deprecated

Check warning on line 654 in src/main/java/org/apache/maven/plugin/resources/remote/AbstractProcessRemoteResourcesMojo.java

View workflow job for this annotation

GitHub Actions / Verify / ubuntu-latest jdk-21-zulu 3.10.0-rc-1

copyFile(java.io.File,java.io.File,java.lang.String,org.apache.maven.shared.filtering.FilterWrapper[]) in org.apache.maven.shared.filtering.FilteringUtils has been deprecated
}

// exclude the original (so eclipse doesn't complain about duplicate resources)
Expand All @@ -663,15 +663,34 @@
return false;
}

private boolean copyProjectRootIfExists(File outputFile, String bundleResourceName) throws IOException {
private boolean copyProjectRootIfExists(
File outputFile, String bundleResourceName, VelocityContext context, String encoding)
throws IOException, MojoExecutionException {
if (!useProjectFiles) {
return false;
}

File source = new File(project.getBasedir(), bundleResourceName);
File templateSource = new File(project.getBasedir(), bundleResourceName + TEMPLATE_SUFFIX);

if (!source.exists() && templateSource.exists()) {
source = templateSource;
}

if (source.exists()) {
getLog().debug("Use project file '" + source + "' as resource");
FilteringUtils.copyFile(source, outputFile, null, null);
if (source == templateSource) {
getLog().debug("Use project file '" + source + "' as resource with Velocity");
try (CachingOutputStream os = new CachingOutputStream(outputFile);
Writer writer = getWriter(encoding, os);
Reader reader = getReader(encoding, source)) {
velocity.evaluate(context, writer, "", reader);
} catch (ParseErrorException | MethodInvocationException | ResourceNotFoundException e) {
throw new MojoExecutionException("Error rendering velocity resource: " + source, e);
}
} else {
getLog().debug("Use project file '" + source + "' as resource");
FilteringUtils.copyFile(source, outputFile, null, null);

Check warning on line 692 in src/main/java/org/apache/maven/plugin/resources/remote/AbstractProcessRemoteResourcesMojo.java

View workflow job for this annotation

GitHub Actions / Verify / ubuntu-latest jdk-17-zulu 3.10.0-rc-1

copyFile(java.io.File,java.io.File,java.lang.String,org.apache.maven.shared.filtering.FilterWrapper[]) in org.apache.maven.shared.filtering.FilteringUtils has been deprecated

Check warning on line 692 in src/main/java/org/apache/maven/plugin/resources/remote/AbstractProcessRemoteResourcesMojo.java

View workflow job for this annotation

GitHub Actions / Verify / macos-latest jdk-21-zulu 3.10.0-rc-1

copyFile(java.io.File,java.io.File,java.lang.String,org.apache.maven.shared.filtering.FilterWrapper[]) in org.apache.maven.shared.filtering.FilteringUtils has been deprecated

Check warning on line 692 in src/main/java/org/apache/maven/plugin/resources/remote/AbstractProcessRemoteResourcesMojo.java

View workflow job for this annotation

GitHub Actions / Verify / macos-latest jdk-8-zulu 3.10.0-rc-1

copyFile(java.io.File,java.io.File,java.lang.String,org.apache.maven.shared.filtering.FilterWrapper[]) in org.apache.maven.shared.filtering.FilteringUtils has been deprecated

Check warning on line 692 in src/main/java/org/apache/maven/plugin/resources/remote/AbstractProcessRemoteResourcesMojo.java

View workflow job for this annotation

GitHub Actions / Verify / ubuntu-latest jdk-25-zulu 3.10.0-rc-1

copyFile(java.io.File,java.io.File,java.lang.String,org.apache.maven.shared.filtering.FilterWrapper[]) in org.apache.maven.shared.filtering.FilteringUtils has been deprecated

Check warning on line 692 in src/main/java/org/apache/maven/plugin/resources/remote/AbstractProcessRemoteResourcesMojo.java

View workflow job for this annotation

GitHub Actions / Verify / macos-latest jdk-25-zulu 3.10.0-rc-1

copyFile(java.io.File,java.io.File,java.lang.String,org.apache.maven.shared.filtering.FilterWrapper[]) in org.apache.maven.shared.filtering.FilteringUtils has been deprecated

Check warning on line 692 in src/main/java/org/apache/maven/plugin/resources/remote/AbstractProcessRemoteResourcesMojo.java

View workflow job for this annotation

GitHub Actions / Verify / ubuntu-latest jdk-8-zulu 3.10.0-rc-1

copyFile(java.io.File,java.io.File,java.lang.String,org.apache.maven.shared.filtering.FilterWrapper[]) in org.apache.maven.shared.filtering.FilteringUtils has been deprecated

Check warning on line 692 in src/main/java/org/apache/maven/plugin/resources/remote/AbstractProcessRemoteResourcesMojo.java

View workflow job for this annotation

GitHub Actions / Verify / ubuntu-latest jdk-21-zulu 3.10.0-rc-1

copyFile(java.io.File,java.io.File,java.lang.String,org.apache.maven.shared.filtering.FilterWrapper[]) in org.apache.maven.shared.filtering.FilteringUtils has been deprecated
}
return true;
}

Expand Down Expand Up @@ -942,7 +961,7 @@
continue;
}

if (copyProjectRootIfExists(outputFile, projectResource)) {
if (copyProjectRootIfExists(outputFile, projectResource, context, bundle.getSourceEncoding())) {
continue;
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@
import org.apache.maven.execution.MavenSession;
import org.apache.maven.plugin.resources.remote.stub.MavenProjectBuildStub;
import org.apache.maven.plugin.resources.remote.stub.MavenProjectResourcesStub;
import org.apache.maven.plugin.testing.AbstractMojoTestCase;

Check warning on line 46 in src/test/java/org/apache/maven/plugin/resources/remote/RemoteResourcesMojoTest.java

View workflow job for this annotation

GitHub Actions / Verify / ubuntu-latest jdk-17-zulu 3.10.0-rc-1

org.apache.maven.plugin.testing.AbstractMojoTestCase in org.apache.maven.plugin.testing has been deprecated

Check warning on line 46 in src/test/java/org/apache/maven/plugin/resources/remote/RemoteResourcesMojoTest.java

View workflow job for this annotation

GitHub Actions / Verify / macos-latest jdk-21-zulu 3.10.0-rc-1

org.apache.maven.plugin.testing.AbstractMojoTestCase in org.apache.maven.plugin.testing has been deprecated

Check warning on line 46 in src/test/java/org/apache/maven/plugin/resources/remote/RemoteResourcesMojoTest.java

View workflow job for this annotation

GitHub Actions / Verify / macos-latest jdk-8-zulu 3.10.0-rc-1

org.apache.maven.plugin.testing.AbstractMojoTestCase in org.apache.maven.plugin.testing has been deprecated

Check warning on line 46 in src/test/java/org/apache/maven/plugin/resources/remote/RemoteResourcesMojoTest.java

View workflow job for this annotation

GitHub Actions / Verify / ubuntu-latest jdk-25-zulu 3.10.0-rc-1

org.apache.maven.plugin.testing.AbstractMojoTestCase in org.apache.maven.plugin.testing has been deprecated

Check warning on line 46 in src/test/java/org/apache/maven/plugin/resources/remote/RemoteResourcesMojoTest.java

View workflow job for this annotation

GitHub Actions / Verify / macos-latest jdk-25-zulu 3.10.0-rc-1

org.apache.maven.plugin.testing.AbstractMojoTestCase in org.apache.maven.plugin.testing has been deprecated

Check warning on line 46 in src/test/java/org/apache/maven/plugin/resources/remote/RemoteResourcesMojoTest.java

View workflow job for this annotation

GitHub Actions / Verify / ubuntu-latest jdk-8-zulu 3.10.0-rc-1

org.apache.maven.plugin.testing.AbstractMojoTestCase in org.apache.maven.plugin.testing has been deprecated

Check warning on line 46 in src/test/java/org/apache/maven/plugin/resources/remote/RemoteResourcesMojoTest.java

View workflow job for this annotation

GitHub Actions / Verify / ubuntu-latest jdk-21-zulu 3.10.0-rc-1

org.apache.maven.plugin.testing.AbstractMojoTestCase in org.apache.maven.plugin.testing has been deprecated
import org.apache.maven.project.MavenProject;
import org.apache.maven.repository.internal.MavenRepositorySystemUtils;
import org.codehaus.plexus.util.FileUtils;
Expand All @@ -58,7 +58,7 @@
/**
* RemoteResources plugin Test Case
*/
public class RemoteResourcesMojoTest extends AbstractMojoTestCase {

Check warning on line 61 in src/test/java/org/apache/maven/plugin/resources/remote/RemoteResourcesMojoTest.java

View workflow job for this annotation

GitHub Actions / Verify / ubuntu-latest jdk-17-zulu 3.10.0-rc-1

org.apache.maven.plugin.testing.AbstractMojoTestCase in org.apache.maven.plugin.testing has been deprecated

Check warning on line 61 in src/test/java/org/apache/maven/plugin/resources/remote/RemoteResourcesMojoTest.java

View workflow job for this annotation

GitHub Actions / Verify / macos-latest jdk-21-zulu 3.10.0-rc-1

org.apache.maven.plugin.testing.AbstractMojoTestCase in org.apache.maven.plugin.testing has been deprecated

Check warning on line 61 in src/test/java/org/apache/maven/plugin/resources/remote/RemoteResourcesMojoTest.java

View workflow job for this annotation

GitHub Actions / Verify / macos-latest jdk-8-zulu 3.10.0-rc-1

org.apache.maven.plugin.testing.AbstractMojoTestCase in org.apache.maven.plugin.testing has been deprecated

Check warning on line 61 in src/test/java/org/apache/maven/plugin/resources/remote/RemoteResourcesMojoTest.java

View workflow job for this annotation

GitHub Actions / Verify / ubuntu-latest jdk-25-zulu 3.10.0-rc-1

org.apache.maven.plugin.testing.AbstractMojoTestCase in org.apache.maven.plugin.testing has been deprecated

Check warning on line 61 in src/test/java/org/apache/maven/plugin/resources/remote/RemoteResourcesMojoTest.java

View workflow job for this annotation

GitHub Actions / Verify / macos-latest jdk-25-zulu 3.10.0-rc-1

org.apache.maven.plugin.testing.AbstractMojoTestCase in org.apache.maven.plugin.testing has been deprecated

Check warning on line 61 in src/test/java/org/apache/maven/plugin/resources/remote/RemoteResourcesMojoTest.java

View workflow job for this annotation

GitHub Actions / Verify / ubuntu-latest jdk-8-zulu 3.10.0-rc-1

org.apache.maven.plugin.testing.AbstractMojoTestCase in org.apache.maven.plugin.testing has been deprecated

Check warning on line 61 in src/test/java/org/apache/maven/plugin/resources/remote/RemoteResourcesMojoTest.java

View workflow job for this annotation

GitHub Actions / Verify / ubuntu-latest jdk-21-zulu 3.10.0-rc-1

org.apache.maven.plugin.testing.AbstractMojoTestCase in org.apache.maven.plugin.testing has been deprecated
static final String DEFAULT_BUNDLE_POM_PATH = "target/test-classes/unit/rrmojotest/bundle-plugin-config.xml";
static final String DEFAULT_PROCESS_POM_PATH = "target/test-classes/unit/rrmojotest/process-plugin-config.xml";

Expand Down Expand Up @@ -165,6 +165,31 @@
assertTrue(file.exists());
}

public void testUseProjectFilesRendersVelocityTemplate() throws Exception {
final MavenProjectResourcesStub project = createTestProject("default-useprojectfiles");
final ProcessRemoteResourcesMojo mojo = lookupProcessMojoWithSettings(project, new String[] {"test:test:1.4"});

setupDefaultProject(project);

FileUtils.fileWrite(
new File(project.getBasedir(), "FILTER.txt.vm").getAbsolutePath(), "local override: $project.name");

String path = pathOf(new DefaultArtifact(
"test", "test", VersionRange.createFromVersion("1.4"), null, "jar", "", new DefaultArtifactHandler()));

File file = new File(path);
file.getParentFile().mkdirs();
buildResourceBundle("default-useprojectfiles-create", null, new String[] {"FILTER.txt.vm"}, file);

setVariableValueToObject(mojo, "useProjectFiles", true);

mojo.execute();

File outputFile = new File((File) getVariableValueFromObject(mojo, "outputDirectory"), "FILTER.txt");
String data = FileUtils.fileRead(outputFile);
assertTrue(data.contains("local override: Test Project default-useprojectfiles"));
}

public void testVelocityUTF8() throws Exception {
final MavenProjectResourcesStub project = createTestProject("default-utf8");
final ProcessRemoteResourcesMojo mojo = lookupProcessMojoWithSettings(project, new String[] {"test:test:1.2"});
Expand Down Expand Up @@ -246,7 +271,7 @@
final ProcessRemoteResourcesMojo mojo =
lookupProcessMojoWithSettings(project, new String[] {"test-filtered-bundles:test-filtered-bundles:2"});

mojo.includeProjectProperties = true;

Check warning on line 274 in src/test/java/org/apache/maven/plugin/resources/remote/RemoteResourcesMojoTest.java

View workflow job for this annotation

GitHub Actions / Verify / ubuntu-latest jdk-17-zulu 3.10.0-rc-1

includeProjectProperties in org.apache.maven.plugin.resources.remote.AbstractProcessRemoteResourcesMojo has been deprecated

Check warning on line 274 in src/test/java/org/apache/maven/plugin/resources/remote/RemoteResourcesMojoTest.java

View workflow job for this annotation

GitHub Actions / Verify / macos-latest jdk-21-zulu 3.10.0-rc-1

includeProjectProperties in org.apache.maven.plugin.resources.remote.AbstractProcessRemoteResourcesMojo has been deprecated

Check warning on line 274 in src/test/java/org/apache/maven/plugin/resources/remote/RemoteResourcesMojoTest.java

View workflow job for this annotation

GitHub Actions / Verify / macos-latest jdk-8-zulu 3.10.0-rc-1

includeProjectProperties in org.apache.maven.plugin.resources.remote.AbstractProcessRemoteResourcesMojo has been deprecated

Check warning on line 274 in src/test/java/org/apache/maven/plugin/resources/remote/RemoteResourcesMojoTest.java

View workflow job for this annotation

GitHub Actions / Verify / ubuntu-latest jdk-25-zulu 3.10.0-rc-1

includeProjectProperties in org.apache.maven.plugin.resources.remote.AbstractProcessRemoteResourcesMojo has been deprecated

Check warning on line 274 in src/test/java/org/apache/maven/plugin/resources/remote/RemoteResourcesMojoTest.java

View workflow job for this annotation

GitHub Actions / Verify / macos-latest jdk-25-zulu 3.10.0-rc-1

includeProjectProperties in org.apache.maven.plugin.resources.remote.AbstractProcessRemoteResourcesMojo has been deprecated

Check warning on line 274 in src/test/java/org/apache/maven/plugin/resources/remote/RemoteResourcesMojoTest.java

View workflow job for this annotation

GitHub Actions / Verify / ubuntu-latest jdk-8-zulu 3.10.0-rc-1

includeProjectProperties in org.apache.maven.plugin.resources.remote.AbstractProcessRemoteResourcesMojo has been deprecated

Check warning on line 274 in src/test/java/org/apache/maven/plugin/resources/remote/RemoteResourcesMojoTest.java

View workflow job for this annotation

GitHub Actions / Verify / ubuntu-latest jdk-21-zulu 3.10.0-rc-1

includeProjectProperties in org.apache.maven.plugin.resources.remote.AbstractProcessRemoteResourcesMojo has been deprecated
setupDefaultProject(project);

project.addProperty("testingPropertyOne", "maven");
Expand Down Expand Up @@ -401,7 +426,7 @@
localRepository.setLayout(new DefaultRepositoryLayout());
request.setLocalRepository(localRepository);
MavenSession session =
new MavenSession(getContainer(), reposession, request, new DefaultMavenExecutionResult());

Check warning on line 429 in src/test/java/org/apache/maven/plugin/resources/remote/RemoteResourcesMojoTest.java

View workflow job for this annotation

GitHub Actions / Verify / ubuntu-latest jdk-17-zulu 3.10.0-rc-1

MavenSession(org.codehaus.plexus.PlexusContainer,org.eclipse.aether.RepositorySystemSession,org.apache.maven.execution.MavenExecutionRequest,org.apache.maven.execution.MavenExecutionResult) in org.apache.maven.execution.MavenSession has been deprecated

Check warning on line 429 in src/test/java/org/apache/maven/plugin/resources/remote/RemoteResourcesMojoTest.java

View workflow job for this annotation

GitHub Actions / Verify / macos-latest jdk-21-zulu 3.10.0-rc-1

MavenSession(org.codehaus.plexus.PlexusContainer,org.eclipse.aether.RepositorySystemSession,org.apache.maven.execution.MavenExecutionRequest,org.apache.maven.execution.MavenExecutionResult) in org.apache.maven.execution.MavenSession has been deprecated

Check warning on line 429 in src/test/java/org/apache/maven/plugin/resources/remote/RemoteResourcesMojoTest.java

View workflow job for this annotation

GitHub Actions / Verify / macos-latest jdk-8-zulu 3.10.0-rc-1

MavenSession(org.codehaus.plexus.PlexusContainer,org.eclipse.aether.RepositorySystemSession,org.apache.maven.execution.MavenExecutionRequest,org.apache.maven.execution.MavenExecutionResult) in org.apache.maven.execution.MavenSession has been deprecated

Check warning on line 429 in src/test/java/org/apache/maven/plugin/resources/remote/RemoteResourcesMojoTest.java

View workflow job for this annotation

GitHub Actions / Verify / ubuntu-latest jdk-25-zulu 3.10.0-rc-1

MavenSession(org.codehaus.plexus.PlexusContainer,org.eclipse.aether.RepositorySystemSession,org.apache.maven.execution.MavenExecutionRequest,org.apache.maven.execution.MavenExecutionResult) in org.apache.maven.execution.MavenSession has been deprecated

Check warning on line 429 in src/test/java/org/apache/maven/plugin/resources/remote/RemoteResourcesMojoTest.java

View workflow job for this annotation

GitHub Actions / Verify / macos-latest jdk-25-zulu 3.10.0-rc-1

MavenSession(org.codehaus.plexus.PlexusContainer,org.eclipse.aether.RepositorySystemSession,org.apache.maven.execution.MavenExecutionRequest,org.apache.maven.execution.MavenExecutionResult) in org.apache.maven.execution.MavenSession has been deprecated

Check warning on line 429 in src/test/java/org/apache/maven/plugin/resources/remote/RemoteResourcesMojoTest.java

View workflow job for this annotation

GitHub Actions / Verify / ubuntu-latest jdk-8-zulu 3.10.0-rc-1

MavenSession(org.codehaus.plexus.PlexusContainer,org.eclipse.aether.RepositorySystemSession,org.apache.maven.execution.MavenExecutionRequest,org.apache.maven.execution.MavenExecutionResult) in org.apache.maven.execution.MavenSession has been deprecated

Check warning on line 429 in src/test/java/org/apache/maven/plugin/resources/remote/RemoteResourcesMojoTest.java

View workflow job for this annotation

GitHub Actions / Verify / ubuntu-latest jdk-21-zulu 3.10.0-rc-1

MavenSession(org.codehaus.plexus.PlexusContainer,org.eclipse.aether.RepositorySystemSession,org.apache.maven.execution.MavenExecutionRequest,org.apache.maven.execution.MavenExecutionResult) in org.apache.maven.execution.MavenSession has been deprecated
session.setProjects(Collections.singletonList(project));

setVariableValueToObject(
Expand Down
Loading