[MARTIFACT-58] add warn log for each dependency stemming from a local repository - #227
[MARTIFACT-58] add warn log for each dependency stemming from a local repository#227sebtiem wants to merge 3 commits into
Conversation
… repository during buildinfo mojo
|
|
||
| if (resultRepo instanceof LocalRepository) { | ||
| log.warn(String.format( | ||
| "The artifact %s:%s:%s is stemming from your local Maven repository. " |
There was a problem hiding this comment.
"from your local Maven repository." => "from a local install to your local Maven repository."
| if (resultRepo instanceof LocalRepository) { | ||
| log.warn(String.format( | ||
| "The artifact %s:%s:%s is stemming from your local Maven repository. " | ||
| + "Please ensure that this is intended. " |
There was a problem hiding this comment.
- " and that your local installed artifact matches public reference from remote."
this helps understand the risk of locally installed releases vs reference published to remote
| log.warn(String.format( | ||
| "The artifact %s:%s:%s is stemming from your local Maven repository. " | ||
| + "Please ensure that this is intended. " | ||
| + "If not, consider removing this artifact and rebuilding.", |
There was a problem hiding this comment.
adding the path to the local repository directory of the artifact version would help delete
|
notice: I don't think the reference to https://issues.apache.org/jira/browse/MARTIFACT-58 is really useful: this PR is much more focused and interesting |
|
@sebtiem small formatting issue: please apply |
|
@hboutemy do you have another issue in mind, I should also attach? Or should i create a new one? |
|
I'm just trying to have the CI building before merging :) |
Following this checklist to help us incorporate your
contribution quickly and easily:
Note that commits might be squashed by a maintainer on merge.
This may not always be possible but is a best-practice.
mvn verifyto make sure basic checks pass.A more thorough check will be performed on your pull request automatically.
mvn -Prun-its verify).If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.
To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.