Skip to content

add push-to-atr profile #584

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hboutemy merged 4 commits into from
Jun 25, 2026
+58 −0
Merged

add push-to-atr profile #584

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
5019104
add push-to-atr profile
hboutemy Jun 21, 2026
bbd7000
configure plugin version in pluginManagement
hboutemy Jun 23, 2026
e47d656
check committes in ATR first
hboutemy Jun 23, 2026
fc23686
ATR is WIP, so is the push-to-atr profile
hboutemy Jun 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 20 additions & 0 deletions docs/src/site/apt/index.apt.vm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -204,6 +204,26 @@ The <<<apache-release>>> Profile

Those files also end up in the staging repository and Maven Central.

* The <<<push-to-atr>>> Profile

Since release 39, <<<push-to-atr>>> profile is provided to help upload built release content to
{{{https://tooling.apache.org/}Apache Tooling}}'s Trusted Releases platform, and compose the release
using {{{https://apache.github.io/tooling-atr-maven-plugin/}<<<atr-maven-plugin>>>}}.
Comment on lines +209 to +211

@slawekjaranowski slawekjaranowski Jun 23, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

by default we only help to upload files other steps need to done in ATR before release start

@hboutemy hboutemy Jun 23, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same as previous: don't get what action you expect from that comment


See ATR's {{{https://release-test.apache.org/tutorial}tutorial}} for a quick introduction: check existing {{{https://release-test.apache.org/committees}committes in ATR}},
you may have to create a project or improve its configuration, for example using
{{{https://github.com/apache/infrastructure-asfyaml/blob/main/README.md#project}<<<project>>> entry in <<<.asf.yaml>>>}}.
Once project is ready, start the release in ATR before doing the staging release with Maven with <<<mvn release:perform -Ppush-to-atr>>>.

Remember that:

* ATR helps your VOTE tracking, but is optional and still in its alpha phase (soon {{{https://github.com/apache/tooling-trusted-releases/issues/512}beta}}),

* this <<<push-to-atr>>> profile is still alpha too, and optional too: you can upload files to ATR and compose your release by hand if anything goes unexpected:
feedback on success and failures is welcome.

[]

Settings Configuration

You can have a look at the page in Apache website
Expand Down
38 changes: 38 additions & 0 deletions pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -137,6 +137,7 @@ under the License.
<version.maven-source-plugin>3.4.0</version.maven-source-plugin>
<!-- for surefire, failsafe and surefire-report -->
<version.maven-surefire>3.5.6</version.maven-surefire>
<version.tooling.atr>1.0.0-alpha-1</version.tooling.atr>
<surefire.version>${version.maven-surefire}</surefire.version>
<version.maven-war-plugin>3.5.1</version.maven-war-plugin>
</properties>
Expand Down Expand Up @@ -355,6 +356,11 @@ under the License.
</dependency>
</dependencies>
</plugin>
<plugin>
<groupId>org.apache.tooling</groupId>
<artifactId>atr-maven-plugin</artifactId>
<version>${version.tooling.atr}</version>
</plugin>
</plugins>
</pluginManagement>
<plugins>
Expand Down Expand Up @@ -526,6 +532,38 @@ under the License.
</build>
</profile>
<!-- END SNIPPET: release-profile -->
<profile>
<id>push-to-atr</id>
<build>
<plugins>
<plugin>
<groupId>org.apache.tooling</groupId>
<artifactId>atr-maven-plugin</artifactId>
<executions>
<execution>
<id>atr-check-composing</id>
<goals>
<goal>check-composing</goal>
</goals>
</execution>
<execution>
<id>upload-to-atr</id>
<goals>
<goal>upload</goal>
</goals>
<configuration>
<files>
<file>${project.build.directory}/${project.artifactId}-${project.version}-source-release.zip</file>

@ctubbsii ctubbsii Jun 30, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I realize this is already merged and I'm late to review, but hard-coding the paths to upload in the plugin config seems like a problem if the hard-coded path is a zip file. zip files don't preserve POSIX execute bits on scripts and other contents, so many projects create a source-release tarball instead, which is configurable in the maven-release-plugin configuration in this parent POM. Any ATR plugin profile should also be similarly capable of being able to handle that.

<file>${project.build.directory}/${project.artifactId}-${project.version}-source-release.zip.sha512</file>

@ctubbsii ctubbsii Jun 30, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this supposed to be the sha512 generated by the net.nicoulaj.maven.plugins:checksum-maven-plugin ? That plugin generates checksums for all artifacts with the classifier source-release, not a specific source-release zip file. This plugin config makes a lot of assumptions about the file name of the source-release artifact.

<file>${project.build.directory}/${project.artifactId}-${project.version}-source-release.zip.asc</file>
</files>
</configuration>
</execution>
</executions>
</plugin>
</plugins>
</build>
</profile>
<profile>
<id>jdk8</id>
<activation>
Expand Down