fix(runtime): separate dash-prefixed Grep patterns with -- in sandbox worker - #3735
Open
yunaremaia wants to merge 2 commits into
Open
fix(runtime): separate dash-prefixed Grep patterns with -- in sandbox worker#3735yunaremaia wants to merge 2 commits into
yunaremaia wants to merge 2 commits into
Conversation
… worker The filesystem worker appended the pattern as a bare positional, so a pattern starting with '-' was parsed by ripgrep as flags. A leading flag exits 1, which maps to an empty match set - reporting strings that exist as absent, with no diagnostic. Adds the same '--' separator the host-local workspace executor already pins (apache#2961), plus a regression test asserting the separator and a successful dash-prefixed search. Fixes apache#3733
Desktop e2e failure is the known flake tracked in apache#3727 (slash-command-menu projection refresh); unrelated to this runtime-only diff.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--argv separator the host-local workspace executor already pins (workspace-executor.ts, from feat(windows): add brokered AppContainer sandbox support #2961), plus a regression test asserting the separator position and a successful-webkit-boxsearch.Test plan
--precedes the pattern in the spawned argv) and passes with itrg -n --no-heading --max-count=5 -webkit-box style.cssexits 1; with--it matcheschmod-restricted files are readable by root, CI runs non-root) - untouched by this diffFixes #3733