Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
67 changes: 63 additions & 4 deletions packages/cli/src/__tests__/pi-tui-runner.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -3059,10 +3059,8 @@ describe('Maka Pi TUI runner', () => {
terminal.input('/session');
terminal.input('\r');
await waitFor(() => plainTerminalOutput(terminal.screenOutput()).includes('↳ Local Read'));
assert.match(
plainTerminalOutput(terminal.screenOutput()),
/Local Read.*subagent:local_read active/,
);
assert.match(plainTerminalOutput(terminal.screenOutput()), /Local Read.*subagent:local_read/);
assert.doesNotMatch(plainTerminalOutput(terminal.screenOutput()), /\bactive\b/);

terminal.input('\x1b[B');
terminal.input('\r');
Expand All @@ -3072,6 +3070,67 @@ describe('Maka Pi TUI runner', () => {
await run;
});

test('shows localized live status badges in the Session picker', async () => {
const terminal = new FakeTerminal(160, 30);
const driver = new SlashCommandDriver([
{
...fakeSessionSummary('session-running', '/repo', 'Running chat'),
status: 'running',
runningTurnIds: ['turn-live'],
},
{
...fakeSessionSummary('session-stale', '/repo', 'Stale running chat'),
status: 'running',
runningTurnIds: [],
},
{
...fakeSessionSummary('session-permission', '/repo', 'Permission chat'),
status: 'waiting_for_user',
blockedReason: 'permission_required',
},
{
...fakeSessionSummary('session-auth', '/repo', 'Auth chat'),
status: 'blocked',
blockedReason: 'auth',
},
{
...fakeSessionSummary('session-noise', '/repo', 'Retryable chat'),
status: 'blocked',
blockedReason: 'tool_failed',
},
{
...fakeSessionSummary('session-stopped', '/repo', 'Stopped chat'),
status: 'aborted',
},
]);
const run = runMakaPiTui({
title: 'Maka',
driver,
cwd: '/repo',
model: 'claude-sonnet-4-5',
connectionSlug: 'claude-subscription',
permissionMode: 'ask',
locale: 'en',
terminal,
});

terminal.input('/session');
terminal.input('\r');
await waitFor(() => plainTerminalOutput(terminal.screenOutput()).includes('needs permission'));
const output = plainTerminalOutput(terminal.screenOutput());
assert.match(output, /Running chat.*session- · running/);
assert.doesNotMatch(output, /Stale running chat.* · running/);
assert.match(output, /Permission chat.*session- · needs permission/);
assert.match(output, /Auth chat.*session- · needs sign-in/);
assert.match(output, /Stopped chat.*session- · stopped/);
assert.match(output, /Retryable chat.*session-/);
assert.doesNotMatch(output, /waiting_for_user|permission_required|tool_failed/);

terminal.input('\x1b');
exitMaka(terminal);
await run;
});

test('imports a foreign session from /session into a fresh handoff turn', async () => {
const terminal = new FakeTerminal();
// No Maka sessions, so the only picker row is the foreign one.
Expand Down
22 changes: 22 additions & 0 deletions packages/cli/src/__tests__/runtime-host-session-driver.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -22,12 +22,34 @@ import {
} from '@maka/runtime-host/protocol';
import {
createRuntimeHostMakaSessionDriver,
runtimeHostSessionSummary,
type RuntimeHostMakaSessionDriverInput,
} from '../runtime-host-session-driver.js';
import { SkillInvocationBlockedError, type MakaAttachedSessionTurn } from '../session-driver.js';
import { WAIT_BUDGET_MS } from './tui-terminal-mock.js';

describe('Runtime Host Maka Session driver', () => {
test('maps authoritative live Turn ids into Session summaries', () => {
assert.deepEqual(
runtimeHostSessionSummary(
sessionProjection({
status: 'running',
liveRunState: { schemaVersion: 1, runningTurnIds: ['turn-1', 'turn-2'] },
}),
).runningTurnIds,
['turn-1', 'turn-2'],
);
const knownEmpty = runtimeHostSessionSummary(
sessionProjection({ liveRunState: { schemaVersion: 1, runningTurnIds: [] } }),
);
assert.equal(Object.hasOwn(knownEmpty, 'runningTurnIds'), true);
assert.deepEqual(knownEmpty.runningTurnIds, []);
assert.equal(
Object.hasOwn(runtimeHostSessionSummary(sessionProjection()), 'runningTurnIds'),
false,
);
});

test('keeps remote Session paths out of Client filesystem policy', async () => {
const driver = createRuntimeHostMakaSessionDriver({
connection: new FakeConnection([]).value,
Expand Down
66 changes: 66 additions & 0 deletions packages/cli/src/__tests__/tui-session-status.test.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,66 @@
import assert from 'node:assert/strict';
import { describe, test } from 'node:test';
import type { SessionSummary } from '@maka/core/session';
import { sessionStatusBadge } from '../tui-session-status.js';

describe('TUI Session status badge', () => {
test('only marks running when the Runtime Host reports a live Turn', () => {
assert.equal(sessionStatusBadge(session({ status: 'running' }), 'en'), undefined);
assert.equal(
sessionStatusBadge(session({ status: 'running', runningTurnIds: [] }), 'en'),
undefined,
);
assert.equal(
sessionStatusBadge(session({ status: 'running', runningTurnIds: ['turn-1'] }), 'en'),
'running',
);
});

test('distinguishes user questions from permission requests with localized copy', () => {
assert.equal(
sessionStatusBadge(session({ status: 'waiting_for_user' }), 'en'),
'waiting for you',
);
assert.equal(
sessionStatusBadge(
session({ status: 'waiting_for_user', blockedReason: 'permission_required' }),
'en',
),
'needs permission',
);
assert.equal(sessionStatusBadge(session({ status: 'waiting_for_user' }), 'zh'), '等你确认');
});

test('marks only actionable blocked reasons and keeps resting rows unmarked', () => {
assert.equal(
sessionStatusBadge(session({ status: 'blocked', blockedReason: 'NO_REAL_CONNECTION' }), 'en'),
'needs connection',
);
assert.equal(
sessionStatusBadge(session({ status: 'blocked', blockedReason: 'auth' }), 'en'),
'needs sign-in',
);
assert.equal(
sessionStatusBadge(
session({ status: 'blocked', blockedReason: 'permission_required' }),
'en',
),
'needs permission',
);
for (const blockedReason of ['tool_failed', 'unknown'] as const) {
assert.equal(
sessionStatusBadge(session({ status: 'blocked', blockedReason }), 'en'),
undefined,
);
}
assert.equal(sessionStatusBadge(session({ status: 'active' }), 'en'), undefined);
assert.equal(sessionStatusBadge(session({ status: 'aborted' }), 'en'), 'stopped');
assert.equal(sessionStatusBadge(session({ status: 'aborted' }), 'zh'), '已中止');
});
});

function session(
overrides: Partial<Pick<SessionSummary, 'status' | 'blockedReason' | 'runningTurnIds'>> = {},
): Pick<SessionSummary, 'status' | 'blockedReason' | 'runningTurnIds'> {
return { status: 'active', ...overrides };
}
9 changes: 6 additions & 3 deletions packages/cli/src/pi-tui-runner.ts
Original file line number Diff line number Diff line change
Expand Up @@ -88,6 +88,7 @@ import { editorTheme, selectListTheme } from './tui-ansi.js';
import { MakaAutocompleteAboveEditorComponent } from './tui-autocomplete-layout.js';
import { createShellRunElapsedTicker } from './shell-run-elapsed-ticker.js';
import { createShellRunHydrationController } from './shell-run-hydration.js';
import { sessionStatusBadge } from './tui-session-status.js';
import {
AttentionController,
DISABLE_FOCUS_REPORTING,
Expand Down Expand Up @@ -2011,18 +2012,20 @@ export async function runMakaPiTui(input: MakaPiTuiInput): Promise<void> {
: projectedSessions;
const items: SelectItem[] = visibleSessions.map(({ session, depth }) => {
const state = availability.get(session.id);
const statusBadge = sessionStatusBadge(session, locale);
const statusDetail = statusBadge ? ` · ${statusBadge}` : '';
const location =
sessionListScope === 'all' && session.cwd ? ` ${basename(session.cwd)}` : '';
const childDetail = session.subagentRuntime
? ` subagent:${session.subagentRuntime.profile} ${session.status}`
? ` subagent:${session.subagentRuntime.profile}`
: '';
return {
value: session.id,

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[P2] Keep the live-status badge visible when resume availability is false

Reachability: ② reasonable failure/recovery path. If a Session's local working directory has been removed or is otherwise unavailable, getSessionResumeAvailability() returns available: false. Even when the Host has authoritatively returned a live runningTurnIds value, this branch renders only the short id and the availability reason, so the picker hides the fact that a Turn is still running.

Could we build the shared description prefix from shortSessionId + statusDetail and use it in both branches, appending the availability reason only for the unavailable case? That keeps the Host-owned live state visible while still explaining why the Session cannot be resumed locally. Please add one focused picker regression covering an unavailable Session with a live Turn.

This is non-blocking; it only affects status visibility on the recovery path.

label: `${depth > 0 ? `${' '.repeat(depth - 1)}↳ ` : ''}${session.name || session.id}`,
description:
state?.available === false
? `${shortSessionId(session.id)} ${state.reason}`
: `${shortSessionId(session.id)}${location}${childDetail} ${session.llmConnectionSlug} ${session.model}`,
? `${shortSessionId(session.id)}${statusDetail} ${state.reason}`
: `${shortSessionId(session.id)}${statusDetail}${location}${childDetail} ${session.llmConnectionSlug} ${session.model}`,
};
});
// Foreign sessions are cwd-scoped; show them in both scope views (they
Expand Down
3 changes: 3 additions & 0 deletions packages/cli/src/runtime-host-session-driver.ts
Original file line number Diff line number Diff line change
Expand Up @@ -1183,6 +1183,9 @@ export function runtimeHostSessionSummary(session: SessionCatalogProjection): Se
status: session.status,
...(session.blockedReason === undefined ? {} : { blockedReason: session.blockedReason }),
...(session.statusUpdatedAt === undefined ? {} : { statusUpdatedAt: session.statusUpdatedAt }),
...(session.liveRunState === undefined
? {}
: { runningTurnIds: [...session.liveRunState.runningTurnIds] }),
...(session.parentSessionId === undefined ? {} : { parentSessionId: session.parentSessionId }),
...(session.branchOfTurnId === undefined ? {} : { branchOfTurnId: session.branchOfTurnId }),
...(session.subagent === undefined ? {} : { subagent: session.subagent }),
Expand Down
70 changes: 70 additions & 0 deletions packages/cli/src/tui-session-status.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,70 @@
import type { SessionSummary } from '@maka/core/session';
import type { UiCatalog, UiLocale } from '@maka/core/ui-locale';

interface TuiSessionStatusCopy {
readonly running: string;
readonly waitingForUser: string;
readonly permissionRequired: string;
readonly connectionRequired: string;
readonly signInRequired: string;
readonly stopped: string;
}

const TUI_SESSION_STATUS_COPY = {
zh: {
running: '进行中',
waitingForUser: '等你确认',
permissionRequired: '需要权限',
connectionRequired: '需要连接',
signInRequired: '需要重新登录',
stopped: '已中止',
},
en: {
running: 'running',
waitingForUser: 'waiting for you',
permissionRequired: 'needs permission',
connectionRequired: 'needs connection',
signInRequired: 'needs sign-in',
stopped: 'stopped',
},
} satisfies UiCatalog<TuiSessionStatusCopy>;

/**
* Present the runtime Session state as compact picker copy.
*
* Persisted `running` is only credible when the Runtime Host also reports a
* live Turn. Non-actionable blocked reasons remain ordinary resumable rows,
* matching Desktop's display projection rather than exposing bookkeeping
* noise as a broken Session.
*/
export function sessionStatusBadge(
session: Pick<SessionSummary, 'status' | 'blockedReason' | 'runningTurnIds'>,
locale: UiLocale,
): string | undefined {
const copy = TUI_SESSION_STATUS_COPY[locale];
switch (session.status) {
case 'active':
return undefined;
case 'running':
return session.runningTurnIds?.length ? copy.running : undefined;
case 'waiting_for_user':
return session.blockedReason === 'permission_required'
? copy.permissionRequired
: copy.waitingForUser;
case 'blocked':
switch (session.blockedReason) {
case 'NO_REAL_CONNECTION':
return copy.connectionRequired;
case 'auth':
return copy.signInRequired;
case 'permission_required':
return copy.permissionRequired;
case 'tool_failed':
case 'unknown':
case undefined:
return undefined;
}
case 'aborted':
return copy.stopped;
}
}