refactor(runtime-host): remove redundant TraceTotals from Session traces - #3440
Open
Sun-GLiang wants to merge 1 commit into
Open
refactor(runtime-host): remove redundant TraceTotals from Session traces#3440Sun-GLiang wants to merge 1 commit into
Sun-GLiang wants to merge 1 commit into
Conversation
Generated-by: Codex
Sun-GLiang
marked this pull request as ready for review
August 21, 2026 16:35
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TraceTotals, its helpers, and the redundant aggregate fields from Core, Runtime, Runtime Host, preload, and Desktop trace shapes.model_callstep prices, preserving unpriced, mixed, retry, and explicit-zero semantics without rescanning attempts.Fixes #3389
Verification
npm test— all workspace tests passednpm run build:testnpm --workspace @maka/desktop run typechecknpm run lintnpm run format:checknode --test --test-concurrency=1 scripts/protocol-epoch-check.test.mjs— 8 passednode scripts/protocol-epoch-check.mjs --base apache/main --head HEAD— protocol changed and epoch moved 35 → 36git diff --check apache/main...HEADReview focus
SESSION_TRACE_SCHEMA_VERSIONintentionally remains 1 because this projection is not persisted. Cross-process compatibility is enforced by Runtime Host compatibility epoch 36.AI use
Select exactly one:
Tool(s) and scope: Codex — issue analysis, implementation, tests, verification, and draft PR preparation.
Checklist
Does this PR entail a change in behavior?