Skip to content

chore(docs): recognize Selector as an Astryx re-export in the surface inventory - #3369

Merged
Astro-Han merged 1 commit into
apache:mainfrom
GabrielDrapor:chore/astryx-inventory-selector
Aug 22, 2026
Merged

chore(docs): recognize Selector as an Astryx re-export in the surface inventory#3369
Astro-Han merged 1 commit into
apache:mainfrom
GabrielDrapor:chore/astryx-inventory-selector

Conversation

@GabrielDrapor

Copy link
Copy Markdown
Contributor

Split out of #2921 per review: a one-line allowlist addition (Selector re-exports from @maka/ui like its siblings) plus the mechanically regenerated inventory rows. No behavior change.

Co-Authored-By: Claude noreply@anthropic.com

https://claude.ai/code/session_01TMwYxgNEbz2RFmuK6AXGcj

… inventory

`Selector` re-exports from @maka/ui like Badge/Card/Button but was missing
from MAKA_UI_ASTRYX_REEXPORTS, so the generated inventory under-reported the
Astryx usage of every file that renders one. Mechanical: one allowlist line
plus the regenerated rows.

Co-Authored-By: Claude <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01TMwYxgNEbz2RFmuK6AXGcj
@GabrielDrapor
GabrielDrapor force-pushed the chore/astryx-inventory-selector branch from 43efba4 to 1e549d2 Compare August 22, 2026 07:29

@Astro-Han Astro-Han left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @GabrielDrapor — reviewed at exact head 1e549d2cd0e169b751f0c6accba395088e9a444f. No findings; approving.

Verification

Ran node scripts/generate-astryx-surface-inventory.mjs in a read-only worktree at this head: the working tree stayed clean (git status --porcelain empty, 190 files aligned, 0 blocker / 0 polish). The committed docs/astryx-surface-file-inventory.md is exactly what the script produces, so there is no hand-edited drift between the generator and its output.

On the change itself

Adding Selector to MAKA_UI_ASTRYX_REEXPORTS matches the actual barrel: @maka/ui re-exports Selector from @astryxdesign/core, the same way it does for Badge, Card, Button and IconButton. Desktop imports Selector from @maka/ui in a number of places (agent graph panel, MCP page, several settings pages), so the twelve inventory rows that gain an Astryx used entry reflect real usage rather than a speculative classification.

The remaining entries in MAKA_UI_ASTRYX_REEXPORTS are already present, so I did not find another re-export that should have been included in the same pass.

Documentation-only correction to a generated inventory; no functional or security surface.


This review was AI-assisted. It is not a substitute for independent human review by a committer.

@Astro-Han
Astro-Han merged commit 41e2454 into apache:main Aug 22, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants