fix(licenses): regenerate the notices after the bundled-font declaration - #3155
Conversation
apache#3140 added the Geist OFL declaration to LICENSE, and the notices generator folds LICENSE into its output, so the committed file has been stale since that merged. `npm run check:third-party-notices` has failed on `main` ever since. Nothing caught it because the Windows `package` job is the only caller of this check, it runs on pull requests alone, and its trigger paths do not include LICENSE — so the PR that caused the drift never ran the job that would have said so. The next PR to touch one of those paths inherited the failure. Regenerated output only: 107 lines added, none removed, all of them the OFL text apache#3140 introduced. Verified under `npm ci` so the dependency closure matches what CI resolves. Claude-Session: https://claude.ai/code/session_014ajaRxC4jydavY9nYUFj5J
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan includes up to 3 reviews per rolling hour; 0 remain after this review. 📝 WalkthroughWhat this PR solves
Source of truth and scopeThe PR extends the existing generated notices file from The change is the smallest coherent solution. It updates only the generated notices file and adds no runtime, policy, CI, or public API changes. Deletions and simplificationNo code or tests can be deleted or simplified without weakening the notices check or removing required license text. Risks and validationThe change adds licensing documentation for bundled fonts. It does not change application behavior or exported entities. Validation included:
The final required-check status remains unverified unless confirmed directly in the repository or CI results. Review-relevant risksThe current diff has a licensing effect because it adds the Geist and Geist Mono SIL Open Font License 1.1 notices. Any material licensing change requires independent human review under repository policy. No other protected-area effect was identified in the current diff. The person performing the merge reviews the final diff, and a maintainer makes the final determination. WalkthroughAdded third-party notices for the bundled Geist and Geist Mono variable webfonts, including attribution details and the complete SIL Open Font License 1.1 text. ChangesFont licensing
Estimated code review effort: 1 (Trivial) | ~2 minutes Merge Risk: ⚪ Minimal · up to This PR only regenerates the third-party notices file to include the bundled-font license text; no actionable merge-blocking risk remains after normal checks and review. Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 3 | ❌ 2❌ Failed checks (2 warnings)
✅ Passed checks (3 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Pull request overview
This PR updates the desktop app’s committed third-party notices output to reflect the recently added Geist / Geist Mono bundled webfont license declaration, fixing the current check:third-party-notices drift on main.
Changes:
- Regenerated
THIRD_PARTY_NOTICES.txtto include the SIL OFL 1.1 notice text for the bundled Geist fonts (as emitted.woff2assets).
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
|
Thanks for the regeneration — I ran the actual generator ( Conclusion: PASS — no blocking findings (no P0/P1/P2). P3 (optional): the generated npm notices path ( AI-assisted review disclosure: this review was produced with AI assistance (pi review subagent on 中文摘要(AI 辅助审查)结论:PASS,无阻塞项。subagent 实际运行生成脚本(npm run generate:third-party-notices)并与 PR 提交的文件逐字节比对——零差异,改动就是规范流程的输出(Geist OFL 块经 VERSION-PINNED LICENSE TEXT OVERRIDE 落入 @ai-sdk/provider-utils 段,与既有 trycua/cua 条目同机制)。其他 notices 制品(cargo 生成器、SVG 的 THIRD_PARTY_LICENSES.txt、git NOTICE)均无需更新,无遗漏。P3(可选):npm notices 路径不在 release-windows-check.yml 的 trigger 列表(只列了 cargo notices 和 git NOTICE),本 PR 自身改动从未跑过 package job——body 已显式延后 LICENSE trigger 缺口,但 npm 路径本身也在 trigger 外,建议补一行或显式声明延后;另外 body 说 "107 lines" 实际是 106。 |
|
LGTM. Merging! |
npm run check:third-party-noticescurrently fails onmain. This regenerates the file it checks.Cause
#3140 added the Geist OFL declaration to
LICENSE. The notices generator foldsLICENSEinto its output, soTHIRD_PARTY_NOTICES.txtwent stale the moment that merged — my PR, my omission.Why CI did not catch it
The Windows
packagejob is the only caller ofcheck:third-party-notices. It runs on pull requests only, and its trigger paths do not includeLICENSE:So the failure surfaced on an unrelated PR, two paths and an hour removed from what caused it. Worth noting for anyone deciding whether that job should also run on
main, or whetherLICENSEbelongs in its trigger paths — I have not changed either here, since both are policy calls.The change
Generator output only. 107 lines added, none removed, all of them the OFL text #3140 introduced.
Verified with
npm cirather than an incremental install, so the dependency closure matches what CI resolves;check:third-party-noticespasses afterward.Sent separately from #3154, which makes this class of failure self-describing — it is what localized this one, in one line, to LICENSE content rather than a dependency change.
Unblocks #3148.