MINOR: Fix "does not exists" grammatical typos in messages and Javadoc#22760
Open
gaoxiaolei-s59 wants to merge 1 commit into
Open
MINOR: Fix "does not exists" grammatical typos in messages and Javadoc#22760gaoxiaolei-s59 wants to merge 1 commit into
gaoxiaolei-s59 wants to merge 1 commit into
Conversation
Fix subject-verb agreement typos ("does not exists" -> "does not exist")
in user-facing diagnostic messages and Javadoc:
- StateDirectory (Javadoc): "does not exists" -> "does not exist"
- TransactionIndex (Javadoc): "doesn't exists" -> "doesn't exist"
- MetadataQuorumCommand: "does not exists!" -> "does not exist!"
Javadoc and string-literal changes only; no behavior change. The
MetadataQuorumCommand test assertion and its test method name are
updated to match.
github-actions
Bot
added
triage
AndrewJSchofield
requested changes
Jul 6, 2026
AndrewJSchofield
left a comment
AndrewJSchofield
left a comment
Member
There was a problem hiding this comment.
Thanks for the PR. Just one trivial comment to address.
| @@ -168,7 +168,7 @@ private static Properties getProperties(File optionalCommandConfig) throws Terse | |||
| return new Properties(); | |||
| } else { | |||
| if (!optionalCommandConfig.exists()) | |||
| throw new TerseException("Properties file " + optionalCommandConfig.getPath() + " does not exists!"); | |||
| throw new TerseException("Properties file " + optionalCommandConfig.getPath() + " does not exist!"); | |||
Member
There was a problem hiding this comment.
It seems to me that this is a serious tool and an exclamation mark is not ideal. Please change it to just does not exist. with a period instead.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #22544, fixing a few more occurrences of the same class of typo found in a repo-wide sweep.
Fixes subject-verb agreement typos ("does not exists" → "does not exist") in user-facing diagnostic messages and Javadoc:
StateDirectory—@throwsJavadoc:"does not exists"→"does not exist"TransactionIndex—@returnJavadoc:"doesn't exists"→"doesn't exist"MetadataQuorumCommand— exception message:"Properties file ... does not exists!"→"...does not exist!"Javadoc and string-literal changes only, with no behavior change. The
MetadataQuorumCommandErrorTestassertion and its test method name are updated to match the corrected message.Reviewers: Andrew Schofield aschofield@confluent.io