[Draft] Authenticated Received Chain - ARC-sealing by agrinchenko · Pull Request #31 · apache/james-jdkim

agrinchenko · 2025-10-07T19:35:02Z

Draft for ARC-sealing for review/comments/feedback. Work in progress.

Fix FWS is not trimmed correctly

- Use goals `single` instead of `attached` by the recommendation at http://maven.apache.org/plugins-archives/maven-assembly-plugin-2.5.5/attached-mojo.html

Following alphabetical order with groupId > artifactId

The JDKIM mailet has been moved into James server project

After removing the mailet (been moved to James), those libs are not necessary anymore.

…es project

- Rewired DMARC into separate module - Added relaxed header alignment for DMARC using PSL list - Removed commons-codec dependency

…ld error

… error

…enkins build

agrinchenko · 2025-10-17T22:54:36Z

Hey guys!

I committed changes with DMARC in a separate module and also implemented both strict and relaxed header checking against PSL list.

The Jenkins build fails though because MockPublicKeyRecordRetrieverDmarc test class that is in DMARC module is being used by test classes in the ARC module. It needs to build apache-dmarc-library-0.6-SNAPSHOT-tests.jar first so that ARC tests can find it. Tried changing a few things in POM, and they did not help. Will appreciate any suggestions. Works fine on my local.

…rent pom'

chibenwa · 2025-10-21T16:12:54Z

I have limited bandwith because of over-committing on another project.

I will take time for a complete review of this work this weekend.

agrinchenko · 2025-10-22T13:49:55Z

Thanks, Benoit! No rush..

arc/src/main/java/org/apache/james/arc/ArcValidationResult.java

chibenwa

I do think we could benefit from updating the documentation (src/site ?) for mentionning arc and dkim support + giving some little code examples.

I (tried to) refrain from doing too much code style related comments but I'd be happy, if you accept, to propose you a changeset to polish a bit this work (i'd PR your branch).

arc/src/main/java/org/apache/james/arc/AuthResultsBuilder.java

dmarc/src/main/java/org/apache/james/dmarc/DMARCVerifier.java

arc/src/main/java/org/apache/james/arc/ArcSignatureRecordImpl.java

epinter · 2025-10-26T15:17:58Z

dmarc/src/main/java/org/apache/james/dmarc/PublicSuffixList.java

+
+    private PublicSuffixList() {}
+
+    public static boolean isPublicSuffix(String domain) {


The PSL can't be used just to know if contains a suffix, it's missing exceptions and wildcard. Many valid domains will not be found.

Thanks for the feedback. I will take a closer look at PSL exceptions and wildcards, I think I just learned something new about PSL.

Thanks for the feedback. I will take a closer look at PSL exceptions and wildcards, I think I just learned something new about PSL.

If you need, here is my library:

https://central.sonatype.com/artifact/dev.pinter.psl/publicsuffixlist

Thanks again, for the pointer to your lib! Nice work! I think it does actually more than what I need for the relaxed domain checking. I took another try at rewriting my initial PSL code to add ability to handle wildcards and exceptions. Checked in.

dmarc/src/main/java/org/apache/james/dmarc/PublicSuffixList.java

epinter · 2025-10-26T15:23:22Z

dmarc/src/main/test/java/org/apache/james/dmarc/PublicSuffixListTest.java

+import static org.junit.Assert.assertTrue;
+
+public class PublicSuffixListTest {
+


If a PSL implementation is to be included here, I think a lot more tests will be needed. My implementation has more than 130 tests. A fail in PSL lookup can make invalid dmarc to pass.

Good to know you have PSL implementation with 130 tests already! I would be glad to integrate with your work and delegate the relaxed org domain determination to your code. Let me know! Essentially I would need to be able to supply FQDN and receive either (1) a relaxed version of it (i.e. PSL public suffix + 1 part to the left of it) or (2) same FQDN if nothing is found in PSL.

Nice work you have on PSL! I think your library does more than what I need for the purposes of relaxed domain alignment. As a first step I rewrote initial PSL code I had to handle wildcards and exceptions, also added more test cases.

- Added ARC validation outcome with details on the failure - Refactored logic such as `computeBTag` into separate methods - Added hard fail whenever multiple From headers detected - Rewrote tag extraction logic to do it all in one pass for efficiency - Simplified getTimeMeasure to use standard Java - Removed unnecessary Overrides

Bumps [org.assertj:assertj-core](https://github.com/assertj/assertj) from 3.26.0 to 3.27.7. - [Release notes](https://github.com/assertj/assertj/releases) - [Commits](assertj/assertj@assertj-build-3.26.0...assertj-build-3.27.7) --- updated-dependencies: - dependency-name: org.assertj:assertj-core dependency-version: 3.27.7 dependency-type: direct:development ... Signed-off-by: dependabot[bot] <support@github.com>

Removed typos

chibenwa · 2026-03-28T18:51:12Z

Last comnit in the README is nice.

I'll commit to do a review, likely next weekend. We shalll eventually merge this work upstream in james-jdkim.

agrinchenko · 2026-03-28T18:58:25Z

Last comnit in the README is nice.

I'll commit to do a review, likely next weekend. We shalll eventually merge this work upstream in james-jdkim.

Thanks! Sorry for the delays; I've been going through some changes lately, but all is good now. Waiting on your review.

mbaechler and others added 30 commits July 5, 2019 09:25

Merge pull request apache#8 from Weiling-Liao/master

22266e5

Fix FWS is not trimmed correctly

JDKIM-42 Upgrade apache parent pom version 18 -> 21

e8a21b0

JDKIM-42 Upgrade maven-assembly-plugin 3.0.0 -> 3.1.1

ab18800

- Use goals `single` instead of `attached` by the recommendation at http://maven.apache.org/plugins-archives/maven-assembly-plugin-2.5.5/attached-mojo.html

JDKIM-42 Upgrade junit 4.10 -> 4.12

bc8ace8

JDKIM-42 Upgrade commons-codec 1.7 -> 1.13

fa03947

JDKIM-42 Upgrade commons-logging 1.1.1 -> 1.2

62408fd

JDKIM-42 Upgrade dnsjava 2.1.1 -> 2.1.9

eabf827

JDKIM-42 Upgrade log4j 1.2.16 -> log4j-core 2.12.1

e3f49cb

JDKIM-42 Upgrade maven-site-plugin 3.3 -> 3.7.1

2ee6bc6

JDKIM-42 Upgrade wagon-ssh 2.0 -> 3.3.3

b4f162c

JDKIM-42 Upgrade maven-bundle-plugin 2.3.7 -> 4.2.1

2d6177a

JDKIM-42 Upgrade maven-compiler-plugin 3.0 -> 3.8.1

c8bc3db

JDKIM-42 Upgrade apache-rat-plugin 0.8 -> 0.13

7b263de

JDKIM-42 Upgrade versions-maven-plugin 2.0 -> 2.7

3d05194

JDKIM-42 Upgrade apache-mime4j 0.8.1 -> 0.8.3

b558816

JDKIM-42 Reorder dependencies in pom files

8a92e65

Following alphabetical order with groupId > artifactId

JDKIM-42 Remove apache-jdkim-mailets

c896a16

The JDKIM mailet has been moved into James server project

JDKIM-42 Remove geronimo libs

82c43f5

After removing the mailet (been moved to James), those libs are not necessary anymore.

JDKIM-42 Update README to state that the mailet has been moved to Jam…

6ce11b2

…es project

JDKIM-44 Use JDK 8 as a target JDK

a3269a8

[JAMES-3226] #comment Added antora docs stub

1005b1c

JDKIM-46 Set up Jenkins build system

ac56007

[Documentation] Links should enforce HTTPS in menus

a5a91b2

[Documentation] Retire HUPA

cb715a8

Upgrade DNS Java 2.1.9 -> 3.4.1

1b04fb8

Upgrade commons-codec 1.13 -> 1.15

087df46

Upgrade junit 4.12 -> 4.13.2

3fa5e75

Upgrade log4j 2.12.1 -> 2.14.1

95862c5

Upgrade wagon-ssh 3.3.3 -> 3.4.3

80a6909

Remove unused log4j

4f4d6ef

epinter and others added 8 commits October 13, 2025 06:56

Remove commons-codec

fb3718f

Rework DMARK and reduce dependencies

dcaec3a

- Rewired DMARC into separate module - Added relaxed header alignment for DMARC using PSL list - Removed commons-codec dependency

Adding DMARC pom.xml that was missing in the previous commit

1f420fd

Remove maven compiler plugin in DMARC pom.xml causing build to fail

36da05e

Add to the maven-compiler-plugin in DMARC pom.xml to fix the auto bui…

0d7b82e

…ld error

Add to the maven-compiler-plugin in ARC pom.xml to fix the auto build…

ac8d95b

… error

Updating ARC pom to make sure it can see DMARC test dependencies on J…

abe368c

…enkins build

Fixing the Jenkins build. Realigning to JDK 11

864a57d

Add missing license info. Reorder 'dmarc' and 'arc' modules in the pa…

2193cdb

…rent pom'

chibenwa reviewed Oct 26, 2025

View reviewed changes

arc/src/main/java/org/apache/james/arc/ArcValidationResult.java Show resolved Hide resolved

chibenwa reviewed Oct 26, 2025

View reviewed changes

epinter reviewed Oct 26, 2025

View reviewed changes

dmarc/src/main/java/org/apache/james/dmarc/PublicSuffixList.java Outdated Show resolved Hide resolved

epinter reviewed Oct 26, 2025

View reviewed changes

agrinchenko and others added 6 commits November 4, 2025 11:09

Updated README to reflect the purpose of the fork

b02988d

Update README.adoc

84d6bd9

Removed typos

Merge branch 'apache:master' into master

4df4d24

Fix site build and ARC/DMARC test support

8cd21d0

agrinchenko force-pushed the master branch from 07618b4 to 8cd21d0 Compare March 28, 2026 18:22

agrinchenko added 2 commits March 28, 2026 14:29

Merge upstream master

8850c77

Updated README to show ARC Test examples

cb4b6ff

This comment was marked as outdated.

Sign in to view

ieugen changed the title ~~First commit~~ [Draft] Authenticated Received Chain - ARC-sealing Mar 30, 2026


		private PublicSuffixList() {}

		public static boolean isPublicSuffix(String domain) {

		import static org.junit.Assert.assertTrue;

		public class PublicSuffixListTest {

Conversation

agrinchenko commented Oct 7, 2025

Uh oh!

agrinchenko commented Oct 17, 2025

Uh oh!

chibenwa commented Oct 21, 2025

Uh oh!

agrinchenko commented Oct 22, 2025

Uh oh!

Uh oh!

chibenwa left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

epinter Oct 26, 2025

Choose a reason for hiding this comment

Uh oh!

agrinchenko Oct 28, 2025

Choose a reason for hiding this comment

Uh oh!

epinter Oct 28, 2025

Choose a reason for hiding this comment

Uh oh!

agrinchenko Nov 4, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

epinter Oct 26, 2025

Choose a reason for hiding this comment

Uh oh!

agrinchenko Oct 28, 2025

Choose a reason for hiding this comment

Uh oh!

agrinchenko Nov 4, 2025

Choose a reason for hiding this comment

Uh oh!

This comment was marked as outdated.

Uh oh!

chibenwa commented Mar 28, 2026

Uh oh!

agrinchenko commented Mar 28, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants