Repository navigation
[Pipe] Unify TsFile parser allocation and resize quotas - #18984
Merged
jt2594838 merged 1 commit intoOct 22, 2026
Merged
Conversation
jt2594838
approved these changes
Oct 22, 2026
2 tasks done
VGalaxies
pushed a commit
to VGalaxies/iotdb
that referenced
this pull request
Oct 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Historical tablet-format synchronization of very wide aligned TsFiles can repeatedly fail parser resizes while much of the global Pipe memory pool remains available. Parser working memory was charged to the tablet-only subquota, and initial allocations checked the existing usage while resizes checked usage including the requested growth.
Introduce a TsFile parser memory block charged to TsFile usage. Allocate it through the same resize path used for later growth, enforcing
0.95 * (tablet threshold + TsFile threshold)against post-allocation combined usage (57% with the default thresholds). This lets parsing use the shared budget while generated tablet events can still allocate memory to make downstream progress. Ordinary tablet/TsFile limits and the global pool capacity remain enforced.Both parser and memory-manager resize exceptions report global usage, tablet/TsFile usage, their individual limits, the combined limit, the protected parser limit, and the requested increment. The new message is available in English and Chinese.
Validation
mvn test-compile -DskipTests -Dcheckstyle.skip=trueand the same command with-P with-zh-locale. Checkstyle was checked separately for the changed production files to stay within the local JVM memory limit.PipeMemoryManagerResizeTestandPipeMemoryManagerTest: 24 tests passed per locale, using JDK 17javac/JUnit with Maven's resolved dependency classpath.The original 200 GB, two-cluster workload has not been rerun; its end-to-end retry count and synchronization duration still need confirmation with this patch.
This PR has: