Repository navigation
Verify node status failover through production RPCs - #18963
Merged
CRZbulabula merged 4 commits intoOct 23, 2026
Merged
Conversation
d-wang-commit
force-pushed
the
fix-node-status-failover-session
branch
from
October 22, 2026 03:14
1a53c98 to
7f25d47
Compare
Open the healthy DataNode session before injecting failures and reuse it for SHOW assertions. Preserve status and quorum checks and use the configured default credentials.
Reuse pre-fault sessions and wait for persistence and process exit. Use A -> B -> C -> A with one fresh-cluster retry, verify SQL after quorum recovery, and remove a DataNode hosting the tested database.
d-wang-commit
force-pushed
the
fix-node-status-failover-session
branch
from
October 22, 2026 08:41
7f25d47 to
0aa69d0
Compare
Retry the attach handshake once while the ConfigNode process is alive. Keep test commands outside the retry and preserve both failures.
Replace JVM instrumentation with production RPCs and process failures. Limit assertions to observable status recovery and registration outcomes.
VGalaxies
pushed a commit
to VGalaxies/iotdb
that referenced
this pull request
Oct 29, 2026
* Reuse the JDBC session in the node status failover test Open the healthy DataNode session before injecting failures and reuse it for SHOW assertions. Preserve status and quorum checks and use the configured default credentials. * Stabilize node status failover integration tests Reuse pre-fault sessions and wait for persistence and process exit. Use A -> B -> C -> A with one fresh-cluster retry, verify SQL after quorum recovery, and remove a DataNode hosting the tested database. * Retry transient JVM attachment failures in node status tests Retry the attach handshake once while the ConfigNode process is alive. Keep test commands outside the retry and preserve both failures. * Verify node status failover through production RPCs Replace JVM instrumentation with production RPCs and process failures. Limit assertions to observable status recovery and registration outcomes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Verify observable recovery through production interfaces
IoTDBNodeStatusFailoverITcould fail before its status assertions because its JVM Attach control channel timed out. Its JDBC observations also introduced a separate dependency: creating or reconnecting a session during a DataNode failure can require storage that is unavailable. Reusing a connection does not rule out driver reconnection.Replace the instrumentation with existing ConfigNode RPCs, the existing DataNode status RPC, and actual process stop/restart operations. Remove
NodeStatusTestAgent. No production API or Ratis implementation changes are required. Fault-window observations useshowCluster,showConfigNodes, andshowDataNodesdirectly; the framework's initial JDBC readiness check still runs while the cluster is healthy.Reduce the existing nine scenarios to five, each with its own cluster:
Wait for successful production responses and the expected status instead of forcing repeated leader transfers. Read polling does not replay mutations or rerun whole failed methods. Confirm process exit before restart and stop all test processes before directory cleanup.
Tests
IoTDBNodeStatusFailoverITand reduced its scenarios from nine to five; no additional test cases.git diff --checkpassed.Side effects and risks
This changes test code only and deliberately narrows coverage. It does not verify SQL routing through a DataNode, login availability during faults, a live partitioned old leader, no-quorum behavior, individual replicas' internal records, exact snapshot/log boundaries, actual JVM shutdown-hook execution, or a fixed Removing intermediate state. The removal scenario checks registration recovery, not data migration correctness. These guarantees must not be inferred from the five passing scenarios.
The change removes Attach and fault-window authentication dependencies; it does not fix the cause of the CI host/JVM pauses or a Ratis product defect. No claim of equivalent Linux concurrent-load validation is made.
This PR has:
Key changed/added classes (or packages if there are too many classes) in this PR
IoTDBNodeStatusFailoverIT: verify observable status recovery and registration through production RPCs and process failures, with isolated clusters and explicit cleanup.NodeStatusTestAgent: removed with the JVM instrumentation control channel.