Repository navigation
Conversation
* Fixed multiple config bugs * fix * Update ConfigRegionStateMachine.java * Address ConfigNode review feedback * Fix compile * Compile fix * Fix NodeManager Sonar issues * Fix ConfigNode WAL recovery and registration review feedback
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
ConfigNode could apply SimpleConsensus plans before their WAL records were durable and report successful node registration after failed consensus writes. This backport persists WAL records before execution and propagates registration failures, rolling back incomplete DataNode/AINode registration.
Backport #17609 (
08380be95ae82bffc9e1aa8adf7cc1a92eb027ee) todev/1.3.Adapted to the 1.3 consensus request, snapshot loading, and runtime configuration APIs. Includes the EN/ZH message constants used by this fix with locale source selection in the ConfigNode module.
Validation
All 44 reactor modules passed the English build and Chinese test compilation. The four affected test classes passed all 19 regression tests.
Also verified EN/ZH key and placeholder parity for all 21 message constants and
git diff --check origin/dev/1.3.This PR has: